Opened 5 months ago

Closed 2 months ago

#26028 closed defect (fixed)

HLS Player doesn't use the centralized Proxy Selector.

Reported by: igt0 Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201807R
Cc: Actual Points:
Parent ID: #21863 Points:
Reviewer: Sponsor:

Description (last modified by igt0)

GeckoHLSPlayer uses the DefaultHttpDataSource to create an Object represents a connection to the remote object referred to by the URL.

And DefaultHttpDataSource doesn't respect proxy values, it uses the URL::openConnection (without Proxy) method provided by the Android SDK instead of the ProxySelector.

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by igt0

Description: modified (diff)

comment:2 Changed 5 months ago by igt0

Description: modified (diff)

comment:3 Changed 5 months ago by igt0

Summary: HLS Player bypasses proxy configurationHLS Player doesn't use the centralized Proxy Selector.

comment:4 Changed 5 months ago by igt0

Mozilla bug used to track this issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1459420

comment:5 Changed 4 months ago by igt0

Merged: https://hg.mozilla.org/mozilla-central/rev/b75e6bb295a9

It will be available in Firefox 62. So we will need to backport to FF61.

comment:6 Changed 3 months ago by sysrqb

Priority: MediumVery High

I think we should backport this after #26401 is merged.

comment:7 Changed 2 months ago by gk

Keywords: TorBrowserTeam201807R added
Status: newneeds_review

comment:8 in reply to:  7 Changed 2 months ago by igt0

I tested and it looks good. LGTM

Replying to gk:

bug_26028 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_26028&id=9feca0864e3511ea2f7c42603bd669bc1294158a) has the backport (it applied cleanly).

comment:9 Changed 2 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fixed with commit 7aeef47671133760672f881b38117cb4070f32b3 on tor-browser-60.1.0esr-8.0-1.

Note: See TracTickets for help on using tickets.