#26036 closed defect (fixed)

macOS regression in crypto_rand.c refactor

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-crypto, refactor, regression, macos, fast-fix
Cc: Actual Points:
Parent ID: #24658 Points:
Reviewer: Sponsor:


The refactoring that created crypto_rand.c is missing includes of sys/syscall.h and sys/random.h. sys/random.h is needed for getentropy() on macOS 10.12 Sierra. Omitting sys/syscall.h might also cause us to fail to detect a getrandom() syscall on Linux when that's supported.

Child Tickets

Change History (3)

comment:1 Changed 21 months ago by catalyst

Status: assignedneeds_review

comment:2 Changed 21 months ago by nickm

Status: needs_reviewmerge_ready

LGTM; will merge once CI agrees with me. :)

comment:3 Changed 21 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

CI likes it; merging!

Note: See TracTickets for help on using tickets.