Opened 2 months ago

Last modified 6 days ago

#26038 needs_information enhancement

Misc Rust/Cargo improvements (incl. use global cargo cache)

Reported by: Hello71 Owned by: Hello71
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, 035-removed-20180711
Cc: Sebastian Actual Points:
Parent ID: Points:
Reviewer: isis Sponsor:

Description

https://cgit.alxu.ca/tor.git/log/?h=misc-rust

for discussion (since nobody cared on #tor-dev): should we use the global cargo cache? I think most C+Rust projects still use the global cache. I tried searching GitHub (https://github.com/search?q=%22CARGO_HOME%22+extension%3Aam&type=Code). I found that tor is the only project that does not. for users who do not care, using the global cache will save download time and bandwidth on repeat builds, and for those who do care, my patch prints a warning so they will know. (maybe it should be downgraded to NOTICE?)

Child Tickets

Change History (9)

comment:1 Changed 2 months ago by Hello71

Status: assignedneeds_review

comment:2 Changed 2 months ago by nickm

Milestone: Tor: 0.3.4.x-final

comment:3 Changed 2 months ago by Hello71

Status: needs_reviewneeds_revision

hm, warning for relative CARGO_HOME doesn't work right now, must fix...

comment:4 Changed 2 months ago by Hello71

Status: needs_revisionneeds_review

missing ; before \\n. why make gotta make shell harder than it already is

comment:5 Changed 2 months ago by asn

Reviewer: isis

comment:6 Changed 6 weeks ago by isis

Cc: Sebastian added
Status: needs_reviewneeds_information

I think I'd like to hear from Sebastian, if possible, about the reasoning for using a different CARGO_HOME originally? Perhaps this had something to do with capturing build artifacts in Jenkins?

comment:7 Changed 6 weeks ago by isis

Milestone: Tor: 0.3.4.x-finalTor: 0.3.5.x-final

Triaging more non-vital tickets into 0.3.5, but we're happy to take this in 0.3.4 if we get to it.

comment:8 Changed 6 weeks ago by isis

FWIW, CI passes.

comment:9 Changed 6 days ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

Note: See TracTickets for help on using tickets.