Opened 5 months ago

Closed 4 months ago

#26039 closed defect (fixed)

<profiledir>/preferences/extension-overrides.js will not be loaded in ESR 60

Reported by: mcs Owned by: pospeselr
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The code that read preferences from <profiledir>/preferences/extension-overrides.js was removed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1413413

We will have to do one of the following:

  1. Restore the code that was removed (but see ticket:25750#comment:8).
  2. Devise another way to handle the preferences that we include in extension-overrides.js

Child Tickets

Attachments (2)

Change History (16)

comment:1 Changed 5 months ago by gk

Can't we just move them into our 000-tor-browser.js file? It might not be ideal but should avoid having extra logic somewhere loading those prefs. And one could argue that those prefs are indeed part of the browser as we ship it.

comment:2 Changed 5 months ago by gk

Priority: MediumVery High

(It needs to be seen whether all those NoScript prefs are still needed anyway).

comment:3 Changed 5 months ago by gk

Keywords: TorBrowserTeam201805 added

comment:4 Changed 5 months ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

comment:5 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201805 removed

Moving our tickets to June 2018

comment:6 Changed 4 months ago by pospeselr

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: assignedneeds_revision

Changed the build process to append the (partially generated) extension-overrides.js settings to 000-tor-browser.js

comment:7 Changed 4 months ago by cypherpunks

You mean needs_review?

comment:8 Changed 4 months ago by pospeselr

Status: needs_revisionneeds_review

comment:9 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201806R removed
Status: needs_reviewneeds_revision

Do we really need all those NoScript preferences with the WebExtension version of NoScript (oh, and I guess this holds for HTTPS-Everywhere as well)? I somehow doubt that (which the needs_revision is for). If that's the case, please remove them (if not, then please mark the ticket as needs_review again). We might want to think about whether we need "sane" defaults for both, though. But that should happen in other tickets during the esr60 stabilization cycle (could you file them if needed)?

comment:10 Changed 4 months ago by gk

Okay, I took the patch as-is to get the tagging and building going (commit 4f7417becede4e116eecade1dfad65f67ccbbe8d on master) but will leave this ticket open to check whether we need a follow-up patch.

comment:11 Changed 4 months ago by gk

I pushed a fixup commit (commit c21b1a526ac1e199990496c234532ed309b6209e), as the macOS bundling was broken without it.

One additional thought I had was that PTConfigs does not seem to be the right place for putting the extension-overrides.js file. Dealing e.g. with pdf.js settings has nothing to do with PT configs.

comment:12 Changed 4 months ago by pospeselr

Posted fixup patch which gets rid of extension-overrides.js altogether, build now dumps pluggable transport and localization settings into a temp file before appending to 000-tor-browser.js

comment:13 Changed 4 months ago by pospeselr

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: needs_revisionneeds_review

comment:14 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, applied to master (commit 8cfb90c7f21a220378adaaa8f5f54ce0e9cccb39).

Note: See TracTickets for help on using tickets.