<profiledir>/preferences/extension-overrides.js will not be loaded in ESR 60

The code that read preferences from /preferences/extension-overrides.js was removed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1413413

We will have to do one of the following:

1. Restore the code that was removed (but see ticket:25750#comment:8).
2. Devise another way to handle the preferences that we include in extension-overrides.js

added TorBrowserTeam201806R component::applications/tor browser ff60-esr owner::pospeselr priority::very high resolution::fixed severity::normal status::closed type::defect labels

Can't we just move them into our 000-tor-browser.js file? It might not be ideal but should avoid having extra logic somewhere loading those prefs. And one could argue that those prefs are indeed part of the browser as we ship it.

(It needs to be seen whether all those NoScript prefs are still needed anyway).

Trac:
Priority: Medium to Very High

Trac:
Keywords: N/A deleted, TorBrowserTeam201805 added

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Moving our tickets to June 2018

Trac:
Keywords: TorBrowserTeam201805 deleted, TorBrowserTeam201806 added

Trac:
0001-Bug-26039-profiledir-preferences-extension-overrides.patch

Changed the build process to append the (partially generated) extension-overrides.js settings to 000-tor-browser.js

Trac:
Status: assigned to needs_revision
Keywords: TorBrowserTeam201806 deleted, TorBrowserTeam201806R added

You mean needs_review?

Trac:
Status: needs_revision to needs_review

Do we really need all those NoScript preferences with the WebExtension version of NoScript (oh, and I guess this holds for HTTPS-Everywhere as well)? I somehow doubt that (which the needs_revision is for). If that's the case, please remove them (if not, then please mark the ticket as needs_review again). We might want to think about whether we need "sane" defaults for both, though. But that should happen in other tickets during the esr60 stabilization cycle (could you file them if needed)?

Trac:
Keywords: TorBrowserTeam201806R deleted, TorBrowserTeam201806 added
Status: needs_review to needs_revision

Okay, I took the patch as-is to get the tagging and building going (commit 4f7417becede4e116eecade1dfad65f67ccbbe8d on master) but will leave this ticket open to check whether we need a follow-up patch.

I pushed a fixup commit (commit c21b1a526ac1e199990496c234532ed309b6209e), as the macOS bundling was broken without it.

One additional thought I had was that PTConfigs does not seem to be the right place for putting the extension-overrides.js file. Dealing e.g. with pdf.js settings has nothing to do with PT configs.

Trac:
0001-Bug-26039-FIXUP-profiledir-preferences-extension-ove.patch

Posted fixup patch which gets rid of extension-overrides.js altogether, build now dumps pluggable transport and localization settings into a temp file before appending to 000-tor-browser.js

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201806 deleted, TorBrowserTeam201806R added

Looks good, applied to master (commit 8cfb90c7f21a220378adaaa8f5f54ce0e9cccb39).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #26073 (moved)

mentioned in issue #26251 (moved)

moved to tpo/applications/tor-browser#26039 (closed)