Opened 5 months ago

Closed 4 weeks ago

#26048 closed defect (fixed)

potentially confusing "restart to update" message in ESR60

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201808R
Cc: antonela, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The new doorhanger-based updater UI includes the following prompt:

After a quick restart, Tor Browser will restore all your open tabs and windows that are not in Private Browsing mode.

(this is updateRestart.message2 in locales/en-US/chrome/browser/browser.dtd).

This message is potentially confusing because it implies that some tabs will be restored, but for most Tor Browser users nothing will be restored. Users may not realize that all of their windows are in private browsing mode.

Child Tickets

Attachments (2)

FF Nightly Update Prompt.png (41.6 KB) - added by mcs 5 months ago.
sample update prompt (from Firefox 61.x Nightly)
revised update prompt.png (25.3 KB) - added by mcs 4 weeks ago.
revised prompt

Download all attachments as: .zip

Change History (9)

comment:1 Changed 5 months ago by mcs

The prompt also includes a button labeled Restart and Restore.

Changed 5 months ago by mcs

sample update prompt (from Firefox 61.x Nightly)

comment:2 Changed 5 months ago by mcs

Here is what the prompt looks like in Firefox Nightly:

sample update prompt (from Firefox 61.x Nightly)

It is the same in Tor Browser except both occurrences of the word "Nightly" are replaced with "Tor Browser."

comment:3 Changed 5 months ago by mcs

Summary: potential confusing "restart to update" message in ESR60potentially confusing "restart to update" message in ESR60

comment:4 Changed 5 months ago by mcs

Cc: antonela brade added

comment:5 Changed 5 weeks ago by sysrqb

I just saw this when updating to 8.0a10 (I have a screenshot but it's basically the same as mcs'). I'm guessing we'll need:

  1. different wording that doesn't imply some tabs will be restored
  2. localization for the new resources

Anything else?

Changed 4 weeks ago by mcs

Attachment: revised update prompt.png added

revised prompt

comment:6 Changed 4 weeks ago by mcs

Keywords: TorBrowserTeam201808R added
Status: newneeds_review

There is not time to add code to Tor Browser 8.0 that retrieves a new localized string from Torbutton, so Kathy and I think we should remove the body of the prompt and use an existing Firefox string for the Restart button label. Here is the result:

revised prompt

It is less than ideal, but not misleading. Here is a patch:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26048-01&id=a0a532d94794647d6d6c172967c9a6654d712736

We can leave this ticket open or create a new one to track progress on a better fix.

comment:7 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. I think we should file a new one, as the message is not confusing anymore. Cherry-picked to tor-browser-60.1.0esr-8.0-1 (commit 5e9fd4fcc131a2f7d17440c739db26f8c1fc893c).

Note: See TracTickets for help on using tickets.