#26057 closed task (fixed)

Make it easy to see in the logs which commit was used in nightly build

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201805R, boklm201805, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When the nightly builds fail, it is useful to see which commit was used. We should make it easy to see it in the logs.

Child Tickets

Change History (3)

comment:1 Changed 11 months ago by boklm

Keywords: TorBrowserTeam201805R boklm201805 added; TorBrowserTeam201805 removed
Status: newneeds_revision

There is a patch to fix that in branch bug_26057:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26057&id=78ab93d70e73cf37550f45d6fb8fd61825bc1e95

Before this patch, the filename for the tor component in the nightly build is:

$ ./rbm/rbm showconf tor filename --target torbrowser-linux-x86_64 --target nightly
tor-master-linux-x86_64-a86e6c

After the patch:

$ ./rbm/rbm showconf tor filename --target torbrowser-linux-x86_64 --target nightly
tor-01d729cbfe88-linux-x86_64-13bdaf

We can now see from the filename (which is included in the logs) that the commit used is 01d729cbfe88.

We are doing the same change in the obfs4, sandbox, tor-launcher and torbutton components.

comment:2 Changed 10 months ago by boklm

Status: needs_revisionneeds_review

comment:3 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit 78ab93d70e73cf37550f45d6fb8fd61825bc1e95).

Note: See TracTickets for help on using tickets.