Opened 4 months ago

Closed 3 months ago

#26058 closed enhancement (fixed)

Revert fix for #18743

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, ff60-esr, TorBrowserTeam201806R
Cc: arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We plan to use identity.fxaccounts.enabled to disable all sync related things in Firefox. (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1434706 for the bug that introduced that pref)

That in turn makes the Torbutton patch we have for #18743 obsolete and we should revert it.

Child Tickets

Change History (3)

comment:1 Changed 3 months ago by gk

Keywords: TorBrowserTeam201806R added
Status: newneeds_review

We are getting errors in the console that look like

[06-15 12:22:32] Torbutton WARN: Error updating the Sync UI: TypeError: document.getElementById(...) is null

bug_26058 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_26058&id=72aacbd7178d50abf2c95c43ce907e65b95ddb1c), which is reverting our fix for #18743, should fix that.

comment:2 Changed 3 months ago by arthuredelstein

Looks good to me!

comment:3 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to master (commit 824e6df6e8177fabcb33dac06142332add64a7dd).

Note: See TracTickets for help on using tickets.