Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#26059 closed task (fixed)

Use mar files from the signed directory when generating incremental mars

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, boklm201805, TorBrowserTeam201805R, tbb-backported
Cc: Actual Points:
Parent ID: #23657 Points:
Reviewer: Sponsor:


When generating incremental mar files with make incrementals-alpha or make update_responses-release, we are generating incremental mar files in the {alpha,release}/unsigned/ directory using mar files from the previous version in that same directory.

If the previous version does not exist in that directory, it is downloaded and the incrementals are generated correctly, using the code-signed osx version. However, if the previous versions was built on this machine, the unsigned directory will contain an unsigned build for the previous version, which will be used to generate the incrementals.

Instead, the {alpha,release}/signed/ directory should be used as the input for the previous version.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: newneeds_review

comment:2 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Applied to master as commit ae1c8fd96fdb9f3208a84cca6ec9c8d546ada459 (I slightly shortened the subject line a bit), thanks.

comment:3 Changed 2 years ago by gk

Keywords: tbb-backported added

Backported to maint-7.5 as commit c4dafdefafde5f6f4208eee508ef244a1333510d.

Note: See TracTickets for help on using tickets.