Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#26062 closed defect (fixed)

client: ControlPort set doesn't mean you're a client

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-roadmap-subtask, tor-client tor-httptunnel
Cc: Actual Points:
Parent ID: #25500 Points:
Reviewer: nickm Sponsor:

Description

Splitting from #19665 to avoid confusion.

This ticket is solely to make a patch so that when the ControlPort is set (Unix or not), we do *not* consider it as a client with any_client_port_set().

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by dgoulet

Keywords: tor-client added
Reviewer: → nickm
Status: assigned → needs_review

See branch ticket26062_034_01 *ONLY* for 034.

Following teor's comment from #19665:

We should split off 59a32e5b4ff210b95bbed294cdc787cb75539da5 into a separate ticket and backport it to 0.2.9 and later. Otherwise, relays with the control port open will warn based on the client required protocols list.

Here is the 029 branch for the backport and should be merged forward _up_ to 033: ticket26062_029_01. There is a possible very trivial conflict since we added HTTPTunnelPort_set later on. I'll let that exercise to the mergerer :).

comment:2 Changed 2 years ago by nickm

Resolution: → fixed
Status: needs_review → closed

lgtm; merged to 029 and forward!

comment:3 Changed 2 years ago by traumschule

Keywords: tor-httptunnel added
Note: See TracTickets for help on using tickets.