Opened 2 years ago

Closed 2 years ago

#26069 closed defect (fixed)

hs-v3: Descriptor signature parsing should have a trailing white-space

Reported by: dgoulet Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 031-backport, 032-backport, 033-backport, tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


From ticket #25552, nickm's comment:

I've reviewed the PR. The biggest issue is related to the use of "\n" signature_str, which I believe should be "\n" signature_str " " instead.

We'll fix it in #25552 for 034 but we need to backport it back to 030 when it was first introduced. It won't affect any tor version on the ability to parse service descriptors. It will just reinforce the security and correctness.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by dgoulet

Status: assignedneeds_review

See branch: bug26069_031_01.

It is OK to backport this up to 034 and we'll adjust #25552 accordingly.

comment:2 Changed 2 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged to 0.3.1 and forward!

Note: See TracTickets for help on using tickets.