patch tor-browser-build.git for Firefox 60 ESR

This ticket is to track progress on getting our builds working based on Firefox 60 ESR.

added TorBrowserTeam201805R component::applications/tor browser ff60-esr owner::tbb-team priority::very high resolution::fixed severity::normal status::closed type::defect labels

Here's my current branch for Linux. It fully builds for multiple locales, and runs and connects to https://check.torproject.org.

https://github.com/arthuredelstein/tor-browser-build/commits/26073 (237be3175b514fc6a5df18ecd37816388bfe62f4)

I'm posting it in case anyone wants to work on specific problems in parallel while I continue to refine these patches. The branch uses:

• the latest torbutton branch #25013 (moved)
• the latest tor-launcher branch from #25750 (moved)
• the latest tor-browser.git branch from #25543 (moved)
• the latest stable noscript
• the current https-everywhere
• rust for building Stylo
• language packs from a Firefox 60 build.

Some obvious things are broken, including:

• self-rando (I temporarily disabled it.)
• torbutton (circuit display doesn't work, security slider can't work because noscript has changed)
• noscript button does not appear on the toolbar

I will shortly post links here to builds for manual testing.

My builds are at: https://people.torproject.org/~arthuredelstein/downloads/26073/

Replying to arthuredelstein:

Some obvious things are broken, including: Torlauncher as well:

Stream isolation broken.

Also nice read :) https://www.morbo.org/2018/05/linux-sandboxing-improvements-in_10.html

Replying to cypherpunks:

Replying to arthuredelstein:

Some obvious things are broken, including: Torlauncher as well:

That Tor Launcher problem is caused by the issue described in #26039 (moved).

Other tasks:

• actually using an esr version of the langpacks
• figuring out how to get the llvm signature check to work again

Trac:
Keywords: TorBrowserTeam201805 deleted, TorBrowserTeam201805R added

Trac:
Keywords: TorBrowserTeam201805R deleted, TorBrowserTeam201805 added

Trac:
Priority: Medium to Very High

figuring out how to get the llvm signature check to work again

For review:

https://github.com/arthuredelstein/tor-browser-build/pull/1

actually using an esr version of the langpacks

https://github.com/arthuredelstein/tor-browser-build/issues/2

Replying to sukhbir:

actually using an esr version of the langpacks

https://github.com/arthuredelstein/tor-browser-build/issues/2

Opened a bug, as asked by the developers in #releng:

https://bugzilla.mozilla.org/show_bug.cgi?id=1463749

Trac:
0001-bug-26073-Migrate-general.useragent.locale-to-intl.l.patch

Hello I attached one fix needed by the torbutton.

https://trac.torproject.org/projects/tor/attachment/ticket/26073/0001-bug-26073-Migrate-general.useragent.locale-to-intl.l.patch

Trac:
Status: new to needs_review

igt0: Could you point me to the branch for this ticket I should review?

https://github.com/azadi/tor-browser-build-1/tree/bug-26073

This branch cherry-picks commits from Arthur's branch but differs by fixing the LLVM signature check (which Arthur just merged.) So you can just merge his branch as most of the changes were lifted from there (and LLVM signature check was merged) but note that it doesn't use master on Tor Launcher and Torbutton, while the one above (bug-26073) does.

This builds on Tor Browser:

+git_hash: '25543+10'
+git_url: https://github.com/arthuredelstein/tor-browser.git

Linux builds fine but Windows fails with:

configure: processing command line
configure: 
configure: error: Option 'CFLAGS=-mwindows -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security' is not recognized

Replying to sukhbir:

Linux builds fine but Windows fails with:

{{{ configure: processing command line configure: configure: error: Option 'CFLAGS=-mwindows -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4 -fno-strict-overflow -Wno-missing-field-initializers -Wformat -Wformat-security' is not recognized }}}

https://searchfox.org/mozilla-central/rev/bf4def01bf8f6ff0d18f02f2d7e9efc73e12c63f/build/moz.configure/warnings.configure#109-115

FWIW: It's not unreasonable to assume that the first esr60-based nightly branch will be tor-browser-60.0.1esr-8.0-1, i.e. being based on Firefox 60.0.1 ESR.

Replying to sukhbir:

https://github.com/azadi/tor-browser-build-1/tree/bug-26073

This branch cherry-picks commits from Arthur's branch but differs by fixing the LLVM signature check (which Arthur just merged.) So you can just merge his branch as most of the changes were lifted from there (and LLVM signature check was merged) but note that it doesn't use master on Tor Launcher and Torbutton, while the one above (bug-26073) does.

Some comments while looking a bit on the branch:

1. We want to use 60.0.1esr for our nightly builds, if that means we need to disable the lang pack signature checks for now, then be it so.

2. https://github.com/azadi/tor-browser-build-1/commit/69874135a6550419f95ef39d41a4e3cc5aa5fa02 should be redone. There is no need to use the cat hack. Instead one can do ./mach configure "Here Come All The Configure Args" and proceed as usual.

Trac:
Status: needs_review to needs_revision