Opened 2 years ago

Closed 2 years ago

#26082 closed defect (fixed)

control: ANY_EVENT_IS_INTERESTING() needs to mask the event before testing

Reported by: dgoulet Owned by: dgoulet
Priority: Very High Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-control, regression
Cc: Actual Points:
Parent ID: Points:
Reviewer: nickm Sponsor:


We merged very recently 0c19ce7bdece5906e035e71d3fb682632c8bb9cb which introduced a problem that made all the control events to not work.

In a nutshell, the macro ANY_EVENT_IS_INTERESTING() is doing it wrong. The event passed to the macro should be masked before tested using EVENT_MASK_. And we shouldn't use EVENT_IS_INTERESTING() which only apply to a single event.

Fortunately, tor wasn't released so we can just fix it.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by dgoulet

Reviewer: nickm
Status: assignedmerge_ready

Branch: bug26082_034_01

comment:2 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed


Note: See TracTickets for help on using tickets.