Opened 2 years ago

Closed 2 years ago

#26101 closed defect (fixed)

Update cov-diff script to understand * character

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: ahf Sponsor:


Some time around GCC 8, I think, gcov added this feature:

Executed basic blocks having a statement with zero execution_count end with ‘*’ character

This change makes our cov-diff script not really work any more.

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by nickm

Status: assignedneeds_review

Please see my branch "bug26101_26102" for the fix for this bug and for #26102. My apologies for the perl.

comment:2 Changed 2 years ago by asn

Reviewer: ahf

comment:3 Changed 2 years ago by ahf

Status: needs_reviewmerge_ready

LGTM as far as I could tell from a quick try.

comment:4 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

thanks; merged!

Note: See TracTickets for help on using tickets.