Opened 3 months ago

Closed 3 months ago

#26117 closed defect (fixed)

AF_UNSPEC are actually valid connected cells

Reported by: mikeperry Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The DELIVERED and OVERHEAD cell count in #25903 used the AF_UNSPEC check to represent validity. In #26072 we discovered that the connected cell processing was wrong. Also, AF_UNSPEC may be used for rend connects.

Not in any released version of tor.

Child Tickets

Change History (2)

comment:1 Changed 3 months ago by mikeperry

Status: newneeds_review

comment:2 Changed 3 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged.

Also added 2b0aab7a6ec487 with comments to explain when the address is UNSPEC. We should do this in general when a bug results from a code misunderstanding.

Note: See TracTickets for help on using tickets.