We should avoid that Tor Launcher and Torbutton get treated as second class add-ons due to them still being based on XPCOM (e.g. getting shown on a separate add-on panel and not listed on the default about:addons page).
Setting extensions.legacy.enabled to true and adding the extensions IDs to extensions.legacy.exceptions should fix that.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Child items ...
Show closed items
Linked items 0
Link issues together to show that they're related.
Learn more.
I noticed it's possible to set "extensions.legacy.enabled" to false and you can still whitelist torbutton and tor-launcher using "extensions.legacy.exceptions". This might be a little safer by still providing a warning for any other legacy extensions installed.
So I'd suggest removing the "extensions.legacy.enabled" line. The other two lines of code look good to me.
I noticed it's possible to set "extensions.legacy.enabled" to false and you can still whitelist torbutton and tor-launcher using "extensions.legacy.exceptions". This might be a little safer by still providing a warning for any other legacy extensions installed.
So I'd suggest removing the "extensions.legacy.enabled" line. The other two lines of code look good to me.
Thanks. I did so and change the exception line and the comment a bit taking into account that we don't want to have a warning for the default them showing up as this is confusing. I removed the whitespace between the extension IDs as sukhbir suggested even though that does not matter.
Applied to tor-browser-60.0.1esr-8.0-1 as commit 30544586f8a98e985e0038b2e905bfddb14e999e.
Trac: Status: needs_review to closed Resolution: N/Ato fixed