Changes between Version 1 and Version 2 of Ticket #26127, comment 4


Ignore:
Timestamp:
May 29, 2018, 7:24:32 PM (15 months ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26127, comment 4

    v1 v2  
    22> A fix for this bug is up in my `bug_26127` (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_26127&id=4eaeeb9b41e6509b97e3dd216a2e92572fc9b37b). Please review.
    33
    4 I noticed it's possible to set "extensions.legacy.enabled" to false and you can still whitelist torbutton and tor-launcher. This might be a little safer by still providing a warning for any other legacy extensions installed.
     4I noticed it's possible to set "extensions.legacy.enabled" to false and you can still whitelist torbutton and tor-launcher using "extensions.legacy.exceptions". This might be a little safer by still providing a warning for any other legacy extensions installed.
    55
    6 But the other two lines of code look fine.
     6So I'd suggest removing the "extensions.legacy.enabled" line. The other two lines of code look good to me.