#26152 closed defect (implemented)

Improve errors on crypto/openssl_version badness

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, tor-testing, 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: catalyst, saper@… Actual Points:
Parent ID: Points:
Reviewer: isis Sponsor:

Description

When these tests fail, they currently do so in an unhelpful way. They should log the offending strings when the version strings don't match.

Extracted from #25549.

Child Tickets

Change History (9)

comment:1 Changed 17 months ago by nickm

Status: assignedneeds_review

Please review bug26152_035 -- PR at https://github.com/torproject/tor/pull/117

comment:2 Changed 17 months ago by nickm

Parent ID: #25549

unparenting, to close parent.

comment:3 Changed 17 months ago by dgoulet

Reviewer: isis

comment:4 Changed 17 months ago by isis

saper had a suggestion on github:

Would that be possible to add something to autoconf tests? It was quite annoying to wait for a long time for the build to finish only to find out in the end. Maybe we could even loop in TOR_SEARCH_LIBRARY to reject non-compliant combinations right away and try other ones.

comment:5 in reply to:  4 Changed 17 months ago by isis

Replying to isis:

saper had a suggestion on github:

Would that be possible to add something to autoconf tests? It was quite annoying to wait for a long time for the build to finish only to find out in the end. Maybe we could even loop in TOR_SEARCH_LIBRARY to reject non-compliant combinations right away and try other ones.


I think this is probably a good idea, as long as the autoconf test also printed out the version mismatch. Also I think we would want a new ticket for this?

comment:6 Changed 17 months ago by isis

Status: needs_reviewneeds_revision

I left a review on the PR. One tiny change needed.

comment:7 Changed 17 months ago by nickm

I'm not sure about that change -- have a look at my response to the comment?

comment:8 in reply to:  7 Changed 17 months ago by isis

Status: needs_revisionmerge_ready

Replying to nickm:

I'm not sure about that change -- have a look at my response to the comment?


Oops, you're correct! Carry on.

comment:9 Changed 16 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged this!

Note: See TracTickets for help on using tickets.