Opened 4 months ago

Closed 4 months ago

Last modified 3 months ago

#26153 closed defect (fixed)

Selfrando builds broken for Firefox 60 ESR

Reported by: sukhbir Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: ahomescu Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Building with Selfrando enabled for the Linux builds returns this error:

 0:06.63 DEBUG: <truncated - see config.log for full output>
 0:06.63 DEBUG: | ++ for orig_path in '"${pathvar[@]}"'
 0:06.63 DEBUG: | ++ local orig_binary=/var/tmp/dist/binutils/bin/gcc
 0:06.63 DEBUG: | ++ [[ /var/tmp/dist/binutils/bin/gcc -ef /var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/gcc ]]
 0:06.63 DEBUG: | ++ true
 0:06.63 DEBUG: | ++ [[ -x /var/tmp/dist/binutils/bin/gcc ]]
 0:06.63 DEBUG: | ++ for orig_path in '"${pathvar[@]}"'
 0:06.63 DEBUG: | ++ local orig_binary=/var/tmp/dist/gcc/bin/gcc
 0:06.63 DEBUG: | ++ [[ /var/tmp/dist/gcc/bin/gcc -ef /var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/gcc ]]
 0:06.63 DEBUG: | ++ true
 0:06.63 DEBUG: | ++ [[ -x /var/tmp/dist/gcc/bin/gcc ]]
 0:06.63 DEBUG: | ++ echo /var/tmp/dist/gcc/bin/gcc
 0:06.63 DEBUG: | ++ break
 0:06.63 DEBUG: | + local orig_binary=/var/tmp/dist/gcc/bin/gcc
 0:06.63 DEBUG: | + exec /var/tmp/dist/gcc/bin/gcc -B/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper -ffunction-sections -fdata-sections -fPIC -std=gnu99 -B /var/tmp/build/firefox-d2fd026be23b/obj-x86_64-pc-linux-gnu/build/unix/gold -Wl,--version
 0:06.63 DEBUG: | collect2 version 6.4.0
 0:06.63 DEBUG: | /var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/ld -plugin /var/tmp/dist/gcc/libexec/gcc/x86_64-pc-linux-gnu/6.4.0/liblto_plugin.so -plugin-opt=/var/tmp/dist/gcc/libexec/gcc/x86_64-pc-linux-gnu/6.4.0/lto-wrapper -plugin-opt=-fresolution=/tmp/ccTz6FcR.res -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lgcc_s --eh-frame-hdr -m elf_x86_64 -dynamic-linker /lib64/ld-linux-x86-64.so.2 -pie /usr/lib/x86_64-linux-gnu/Scrt1.o /usr/lib/x86_64-linux-gnu/crti.o /var/tmp/dist/gcc/lib/gcc/x86_64-pc-linux-gnu/6.4.0/crtbeginS.o -L/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper -L/var/tmp/build/firefox-d2fd026be23b/obj-x86_64-pc-linux-gnu/build/unix/gold -L/var/tmp/dist/gcc/lib/gcc/x86_64-pc-linux-gnu/6.4.0 -L/var/tmp/dist/gcc/lib/gcc/x86_64-pc-linux-gnu/6.4.0/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/var/tmp/dist/gcc/lib/gcc/x86_64-pc-linux-gnu/6.4.0/../../.. --version -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /var/tmp/dist/gcc/lib/gcc/x86_64-pc-linux-gnu/6.4.0/crtendS.o /usr/lib/x86_64-linux-gnu/crtn.o
 0:06.63 DEBUG: | collect2: fatal error: ld terminated with signal 6 [Aborted]
 0:06.63 DEBUG: | compilation terminated.
 0:06.63 DEBUG: | Could not open output file: a.out
 0:06.63 DEBUG: | ld: src/Support/posix/Debug.cpp:36: void Error::printf(const char*, ...): Assertion `false' failed.
 0:06.63 ERROR: Command `/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper/gcc -std=gnu99 -B /var/tmp/build/firefox-d2fd026be23b/obj-x86_64-pc-linux-gnu/build/unix/gold -Wl,--version` failed with exit status 1.
 0:06.67 *** Fix above errors and then restart with\
 0:06.67                "/usr/bin/make -f client.mk build"
 0:06.67 make: *** [configure] Error 1

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by boklm

Which selfrando version was used?

In #16472 we are updating selfrando from 0.3.3 to 0.4.1, so it could be useful to check if it is still broken with 0.4.1.

comment:2 in reply to:  1 Changed 4 months ago by sukhbir

Replying to boklm:

Which selfrando version was used?

In #16472 we are updating selfrando from 0.3.3 to 0.4.1, so it could be useful to check if it is still broken with 0.4.1.

I tried with 0.4.1 and got the same error. I will try updating binutils to see if it helps.

I reported this issue upstream at https://github.com/immunant/selfrando/issues/63

Last edited 4 months ago by sukhbir (previous) (diff)

comment:3 Changed 4 months ago by gk

Cc: ahomescu added
Parent ID: #26073

comment:4 Changed 4 months ago by sukhbir

Status: newneeds_review

selfrando 0.4.2 resolves this issue as discussed in the upstream ticket. We are now able to build Firefox with selfrando enabled.

For review:

https://github.com/azadi/tor-browser-build-1/tree/bug-26153

comment:5 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806R added

comment:6 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master with commit 4074cbc2a727daf51ff9fdab29e0a0da3ec078aa.

comment:7 Changed 3 months ago by gk

This breaks our 32bit builds as the linker is running out of address space, so I pushed a fixup commit (8b30ee00debb11a1c165435d304a406c8408f216) to master to just have selfrando for 64bit for now. I opened #26323 to move our 32bit Linux builds to 64bit hosts.

Note: See TracTickets for help on using tickets.