Opened 4 months ago

Closed 4 months ago

#26159 closed enhancement (fixed)

Replace Gson with Jackson in metrics-lib

Reported by: karsten Owned by: karsten
Priority: High Milestone: metrics-lib 2.4.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Related to Onionoo ticket #25848, we should replace Gson with Jackson in metrics-lib.

Otherwise, if we don't switch here, Onionoo will have to include two dependencies in order to parse CollecTor's index.json using metrics-lib and to format and parse its various JSON files in its status/ and out/ directories.

Generally, we'll want to switch in other applications that depend on metrics-lib, and then we'll want to have a single dependency for JSON parsing/formatting in those applications.

Setting priority to high, because we should ideally put out a release with this change in the next few days and then releases of all other applications by the end of this month.

Child Tickets

Change History (5)

comment:1 Changed 4 months ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

comment:2 Changed 4 months ago by karsten

Status: acceptedneeds_review

comment:3 Changed 4 months ago by iwakeh

Status: needs_reviewmerge_ready

The changes are fine. All ant tests and checks pass. The indexNode functionality can read a current index.json and writes an identical one locally.

Ready to merge.

comment:4 Changed 4 months ago by karsten

Fantastic! I'll include this commit in a pre-release tarball by Wednesday evening, unless I spot any issues myself. Thanks!

comment:5 Changed 4 months ago by karsten

Milestone: metrics-lib 2.4.0
Resolution: fixed
Status: merge_readyclosed

Merged and released as part of metrics-lib 2.4.0. Closing. Thanks!

Note: See TracTickets for help on using tickets.