#26165 closed task (fixed)

Make it possible to use gcc:var/setup without hardening wrapper

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, boklm201805, TorBrowserTeam201805R
Cc: Actual Points:
Parent ID: #26073 Points:
Reviewer: Sponsor:

Description

In projects/gcc/config we define var/setup which can be used in the build scripts from other components to setup gcc. It is however assuming we want to use hardening-wrapper, which prevents us from using it in projects/firefox/build to setup a gcc host compiler in the Windows build.

It also seems we want to use gcc to build llvm (as part of the changes for #26073), without hardening-wrapper:
https://github.com/arthuredelstein/tor-browser-build/commit/80c6edec3de1b3a2a1d8f879c95b0bf804cdf9f0

Child Tickets

Change History (5)

comment:2 in reply to:  1 Changed 17 months ago by boklm

Keywords: TorBrowserTeam201805R added
Parent ID: #26073
Status: newneeds_review

Replying to boklm:

I am now trying this patch:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26165&id=0bee21ddba177e8217091df8b22e7b184378fbaa

I checked that hardening of the Linux and Windows builds is still good with this patch.

comment:3 Changed 17 months ago by boklm

Keywords: TorBrowserTeam201805 added; TorBrowserTeam201805R removed
Status: needs_reviewneeds_revision

Because of #26185 it is not easy to override var/hardenned_cc. To avoid that, we should call it hardenned_cc instead of var/hardenned_cc (until #26185 is fixed).

comment:4 Changed 17 months ago by boklm

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: needs_revisionneeds_review

comment:5 Changed 17 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Merged to master with commit b1e6dd922f17555ad153cd9e05997ca41e50417a.

Note: See TracTickets for help on using tickets.