Opened 3 years ago

Closed 3 years ago

#26178 closed task (fixed)

Release metrics-lib 2.4.0

Reported by: karsten Owned by: karsten
Priority: Medium Milestone: metrics-lib 2.4.0
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: iwakeh, irl Sponsor:

Description

Let's release metrics-lib 2.4.0 including the #26159 change, so that we can make similar changes in applications using metrics-lib (#26162, #25848, #26169, #26163).

I'm going to prepare a pre-release tarball today.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by iwakeh

Reviewer: iwakeh, irl

comment:3 Changed 3 years ago by iwakeh

The pre-release was produced with a very old java update-version Created-By: 1.8.0_121-b13 (Oracle Corporation) from January 2017, current is 171 from April 2018 (cf. Oracle release listing and critical patch descriptions). The difference leads to unreproducible bytecode for DescriptorReaderImpl. I don't have that release at hand anymore.

All other checks and tests passed. If irl maybe can confirm using an older Java?

Last edited 3 years ago by iwakeh (previous) (diff)

comment:4 Changed 3 years ago by iwakeh

<Nitpick>
I'd rather write

   - Replace Gson with Jackson. Applications must provide Jackson
-    2.8.6 or higher as dependency and do not need to provide Gson as
+    2.8.6 or compatible as dependency and do not need to provide Gson as
     dependency anymore.

we don't know when a jackson release breaks earlier releases.
</Nitpick>

Last edited 3 years ago by iwakeh (previous) (diff)

comment:5 Changed 3 years ago by karsten

Oops! That's probably related to me having some brew-related issues and dumping all brew packages. I'll install a new Java version and prepare a new tarball later today. Sorry!

I'll also update the change log entry as suggested.

comment:6 Changed 3 years ago by iwakeh

Status: needs_reviewneeds_revision

Changing status. So it'll be easier to notice the update.

comment:7 Changed 3 years ago by karsten

Status: needs_revisionneeds_review

comment:8 Changed 3 years ago by iwakeh

Status: needs_reviewmerge_ready

All fine and bytecode is reproducible now!
Ready to release.

comment:9 Changed 3 years ago by karsten

Milestone: metrics-lib 2.4.0
Resolution: fixed
Status: merge_readyclosed

metrics-lib 2.4.0 is released as of today. Closing. Thanks!

Note: See TracTickets for help on using tickets.