#26200 closed enhancement (fixed)

Bandwidth List format specification: add KeyValues counting errors in Bandwidth Lines

Reported by: juga Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-bwauth, bwauth, specification, tor-spec
Cc: teor Actual Points:
Parent ID: #25925 Points:
Reviewer: Sponsor:

Description (last modified by juga)

they could be useful to understand which relays fail to be measured and why, to solve #16559

So far we thought to add:

  • success
  • error_stream
  • error_circuit
  • error_misc

Edit: to solve #16559

Child Tickets

Change History (8)

comment:1 Changed 16 months ago by juga

Description: modified (diff)

comment:2 Changed 16 months ago by juga

Status: newneeds_review

comment:3 Changed 16 months ago by teor

Keywords: tor-spec added
Milestone: Tor: 0.3.5.x-final
Status: needs_reviewneeds_revision

The spec is missing "error_misc", but the example contains "error_misc".

When you label sbws fields "Exactly once." you are saying that they will always be in every line, in every future version.
If you want the flexibility to remove fields in later versions, please label them "Zero or one time.".

When you label sbws fields "Exactly once." you are saying that they have always been in every line, in every past version.
That's not true of the fields you just added, so please think about labeling them "Zero or one time.".
(Or you can just tell me that you're still developing sbws, and so you can break compatibility. That's ok, too.)

comment:4 Changed 16 months ago by juga

Status: needs_revisionneeds_review

Last commits should fix what you commented.

comment:5 Changed 16 months ago by teor

Status: needs_reviewmerge_ready
Type: defectenhancement

Looks good to me!

comment:6 Changed 16 months ago by juga

Parent ID: #25925

comment:7 Changed 16 months ago by juga

Keywords: tor-bwauth added; tor-dirauth removed

comment:8 Changed 15 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.