Opened 7 months ago

Closed 6 months ago

#26205 closed defect (fixed)

Don't build the uninstaller for Windows during Firefox compilation

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: sukhbir Actual Points:
Parent ID: #26203 Points:
Reviewer: Sponsor:

Description

IIRC the build is strictly speaking still failing for us as Firefox wants to build the uninstaller at the end of the build process using NSIS. But we don't want that. Probably needs an additional patch to fix that properly.

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by gk

Cc: sukhbir added; sukhe removed

comment:2 Changed 6 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201805 removed

Moving our tickets to June 2018

comment:3 Changed 6 months ago by boklm

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

comment:4 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Let's take that one for now to get the build going and think about a better patch later on. I committed the fix in commit 0f6ebe396fad0834388fd2424218582b32493816. on master.

Note: See TracTickets for help on using tickets.