Opened 5 months ago

Closed 4 months ago

#26206 closed defect (fixed)

Ship pthread related dll where needed

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: sukhbir Actual Points:
Parent ID: #26203 Points:
Reviewer: Sponsor:

Description

We enable pthread support for our Windows builds with #25832. IIRC things broke at least on 32bit Windows for me if we don't bundle the respective dll. I tested #25895 and my expert bundle was broken without it. I doubt, though, that this is an expert bundle-only thing as we use pthread in our cross-build for Windows now as well.

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by gk

Cc: sukhbir added; sukhe removed

CCing the real sukhe

comment:2 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201805 removed

Moving our tickets to June 2018

comment:3 Changed 4 months ago by boklm

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

comment:4 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master with commit 907be0ba29c55bac51f47afe1cf8777c5037ffe6.

Note: See TracTickets for help on using tickets.