Opened 4 months ago

Closed 8 weeks ago

Last modified 8 weeks ago

#26210 closed enhancement (fixed)

Stem test for GETINFO md/all

Reported by: rl1987 Owned by: atagar
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Stem Version:
Severity: Normal Keywords: tor-client, tor-control, microdesc, 035-removed-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description


Child Tickets

Change History (6)

comment:1 Changed 4 months ago by rl1987

Type: defectenhancement

comment:2 Changed 3 months ago by teor

Parent ID: #8323

GETINFO md/all is now implemented in Tor master and documented in control-spec.txt.

comment:3 Changed 3 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:4 Changed 8 weeks ago by atagar

Resolution: fixed
Status: newclosed

Thanks rl1987! Stem now uses 'GETINFO md/all' when it's available rather than reading descriptors from disk...

https://gitweb.torproject.org/stem.git/commit/?id=ac2b277

We already had a simple integ test for this...

https://gitweb.torproject.org/stem.git/tree/test/integ/control/controller.py#n1149

This only is invoked when running tests that require network connectivity (via 'run_tests.py --integ --target ONLINE'). Note that this will *not* be exercised with the present tor git codebase because it reports its version as '0.3.5.0-alpha-dev' rather than 0.3.5.1-alpha or above (as documented in the spec).

Made a little hack to exercise this new code with the integ test.

comment:5 in reply to:  4 Changed 8 weeks ago by teor

Replying to atagar:

Note that this will *not* be exercised with the present tor git codebase because it reports its version as '0.3.5.0-alpha-dev' rather than 0.3.5.1-alpha or above (as documented in the spec).

The spec guarantees that all Tor versions 0.3.5.1-alpha and later will implement this feature. We can't guarantee that all Tor versions 0.3.5.0-alpha-dev implement this feature, because it was merged partway through 0.3.5.0-alpha-dev.

comment:6 Changed 8 weeks ago by atagar

Thanks teor. Yup, I know - just wanted to ensure rl1987 knew that stem won't be exercising this functionality until tor does a version bump since this ticket was specifically asking for a test.

Note: See TracTickets for help on using tickets.