#26219 closed defect (fixed)

about:tor page is not loading in pre-nightly Tor Browser builds based on ESR60

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201805R
Cc: igt0, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Testing a pre-nightly Tor Browser build based on ESR60 it turns out the about:tor page is not loading. In the error console exceptions are thrown:

[Exception... "Component returned failure code: 0x80004004 (NS_ERROR_ABORT) [nsIPrefBranch.getComplexValue]"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: jar:file:///path/to/tor-browser/tor-browser_en-US/Browser/browser/omni.ja!/components/nsBrowserContentHandler.js :: get startPage :: line 660"  data: no]

I guess, not treating that browser.startup.homepage as preference with a complex value is not working as well as we thought.

(However, it worked while I was testing the patch for #26100 for some reason).

Child Tickets

Change History (6)

comment:1 Changed 19 months ago by gk

After some experimentation I cam up with the patch in bug_26219_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_26219_v2&id=524b130db463a1dc7af9aa7a678b66bbc265402e) which seems to appease all involved parties. Please review.

comment:2 Changed 19 months ago by cypherpunks

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: newneeds_review

comment:3 Changed 19 months ago by igt0

I tested the patch and it works.

comment:4 in reply to:  3 ; Changed 19 months ago by gk

Replying to igt0:

I tested the patch and it works.

Thanks, do you feel this could get merged to master as-is or should I change something?

comment:5 in reply to:  4 Changed 19 months ago by igt0

It should be merged to master.

I think the approach was not working previously because we were not writing in the root pref branch.

Replying to gk:

Replying to igt0:

I tested the patch and it works.

Thanks, do you feel this could get merged to master as-is or should I change something?

comment:6 Changed 19 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, done with commit 07bdf93e5a4545d33e9204192eab60fd508a02da on master.

Note: See TracTickets for help on using tickets.