Opened 7 weeks ago

Closed 4 weeks ago

#26221 closed enhancement (fixed)

Backport patch for bug 1444532 to Tor Browser stable (7.5)

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-crash, TorBrowserTeam201806R
Cc: arthuredelstein, boklm, mcs, brade, pospeselr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have some crashes that might fit to the problem fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1444532 (see for instance latest comments in #22158, maybe even #20390). We should try to backport that patch to Tor Browser 7.5.

Child Tickets

Change History (6)

comment:1 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201805R added; TorBrowserTeam201805 removed
Status: newneeds_review

bug_26221 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_26221&id=67754dfbbb2c6f20dda9d45c542635b327cb7004) has the backport (It applied cleanly to ESR 52). Please have a look at it.

comment:2 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201805R removed

Moving review tickets to June.

comment:3 Changed 4 weeks ago by gk

Cc: boklm mcs brade pospeslr added

That's the remaining bit blocking the 52.9.0esr-based tor-browser branch.

comment:4 Changed 4 weeks ago by gk

Cc: pospeselr added; pospeslr removed

comment:5 Changed 4 weeks ago by boklm

This looks good to me. It seems that before this patch the SHA256 function was never modified, neither in master or the esr52 branch.

comment:6 in reply to:  5 Changed 4 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to boklm:

This looks good to me. It seems that before this patch the SHA256 function was never modified, neither in master or the esr52 branch.

The issue was there right from the beginning when Arthur's patch (https://hg.mozilla.org/mozilla-central/rev/76cee391a698) landed. Thanks for the review. This got applied to tor-browser-52.8.0esr-7.5-1 (commit 4edbd21ab9244671cb77cf9a4de5e1126079146e).

Note: See TracTickets for help on using tickets.