#26225 closed defect (fixed)

Jenkins test failure: test_get_microdescriptors - test may be unreliable

Reported by: dmr Owned by: dmr
Priority: Medium Milestone:
Component: Archived/Stem Version:
Severity: Normal Keywords: testing
Cc: atagar Actual Points:
Parent ID: Points:
Reviewer: atagar Sponsor:

Description

A recent Jenkins test run (`Build #3443 (May 25, 2018 9:40:56 PM) `) indicates that our test_get_microdescriptors test may be a bit unreliable:

======================================================================
21:43:42 ERROR: test_get_microdescriptors
21:43:42 ----------------------------------------------------------------------
21:43:42 Traceback (most recent call last):
21:43:42   File "/srv/jenkins-workspace/workspace/stem-tor-ci/test/require.py", line 58, in wrapped
21:43:42     return func(self, *args, **kwargs)
21:43:42   File "/srv/jenkins-workspace/workspace/stem-tor-ci/test/integ/control/controller.py", line 1164, in test_get_microdescriptors
21:43:42     for desc in controller.get_microdescriptors():
21:43:42   File "/srv/jenkins-workspace/workspace/stem-tor-ci/stem/control.py", line 488, in wrapped
21:43:42     for val in func(self, *args, **kwargs):
21:43:42   File "/srv/jenkins-workspace/workspace/stem-tor-ci/stem/control.py", line 1773, in get_microdescriptors
21:43:42     raise stem.OperationFailed(message = "Data directory doens't contain cached microescriptors (%s)" % cached_descriptor_path)
21:43:42 OperationFailed: Data directory doens't contain cached microescriptors (/srv/jenkins-workspace/workspace/stem-tor-ci/test/data/cached-microdescs)

Later test runs have passed, and nothing major has changed in the code.

Child Tickets

Change History (3)

comment:1 Changed 21 months ago by dmr

Cc: atagar added
Owner: changed from atagar to dmr
Reviewer: atagar
Status: newassigned

Can't assign and switch status in the same step, so here's an intermediate edit.

comment:2 Changed 21 months ago by dmr

Status: assignedneeds_review

I tried for a while to reproduce this, but wasn't able to.
However, some of the test output tripped me up to the potential cause.

So I've pushed a set of changes that I think will make this test more reliable.
GitHub pull request (branch head 6ddc67f62689e5b34a1a969a1d022c3c653599b5)

I dug into the original implementation of get_microdescriptors() and the evolution of its test case, just to try to understand if something more was going on here. As far as I can reason about this without reproducing the failure, these are appropriate changes to make. Please feel free to take all or a subset!

comment:3 Changed 21 months ago by atagar

Resolution: fixed
Status: needs_reviewclosed

Thanks Dave! Merged.

Note: See TracTickets for help on using tickets.