#26234 closed task (fixed)

Add support in update_responses for redirecting old versions to a separate directory

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: boklm Actual Points:
Parent ID: #26050 Points:
Reviewer: Sponsor:

Description

In order to be able to do "watershed" updates without changing the update URLs, we should add an option in the update_responses script to redirect old versions to a separate directory.

Child Tickets

Change History (3)

comment:1 Changed 14 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201805 removed

Moving our tickets to June 2018

comment:2 Changed 13 months ago by boklm

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

There is a patch for review in branch bug_26234_v2:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_26234_v2&id=3cab74acf8a2f2a311c133544ccc8c00a43e00a2

In this patch we add support for the htaccess_rewrite_rules option, which we can use in #26050 to redirect 7.5 users to a different directory containing the 8.0 update:

diff --git a/projects/release/update_responses_config.yml b/projects/release/update_responses_config.yml
index 1a9b0cf..c9cd675 100644
--- a/projects/release/update_responses_config.yml
+++ b/projects/release/update_responses_config.yml
@@ -23,6 +23,9 @@ build_targets:
     osx64: Darwin_x86_64-gcc3
 channels:
     [% pc('firefox', 'var/torbrowser_update_channel') %]: [% c("var/torbrowser_version") %]
+htaccess_rewrite_rules:
+    alpha: |
+        RewriteRule ^([^/]+/7\.5.+/.*) https://aus1.torproject.org/torbrowser/update_watershed_7.5/alpha/$1 [last]
 versions:
     [% c("var/torbrowser_version") %]:
 [% IF c("var/create_unsigned_incrementals") -%]

I did not check yet that the rewrite rule in this example is working correctly.

comment:3 Changed 13 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Path looks good. Merged to master (commit 3cab74acf8a2f2a311c133544ccc8c00a43e00a2).

Note: See TracTickets for help on using tickets.