Opened 4 months ago

Closed 8 weeks ago

#26237 closed defect (fixed)

Back and Forward button should be on the left side of the toolbar

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201807R
Cc: arthuredelstein, ux-team, intrigeri Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In nightly build based on ESR60 the buttons are next to the search bar. But they should be on the left side of the toolbar instead.

Child Tickets

Attachments (2)

toolbar_26237.png (30.4 KB) - added by arthuredelstein 3 months ago.
toolbar_26237+1.png (24.6 KB) - added by arthuredelstein 2 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 4 months ago by cypherpunks

Reload button doesn't appear as well. NoScript ends up in the toolbar after an update.

(Wish: Set Density to compact by default (see >Customize))

Edit: HTTPS Everywhere eventually appears in the toolbar as well.

Last edited 4 months ago by cypherpunks (previous) (diff)

comment:2 Changed 3 months ago by arthuredelstein

Cc: arthuredelstein added

Changed 3 months ago by arthuredelstein

Attachment: toolbar_26237.png added

comment:3 Changed 3 months ago by arthuredelstein

Here's a proposed patch to try to clean up the toolbar:
https://github.com/arthuredelstein/tor-browser/commit/26237

I moved the HTTPS-Everywhere button off the toolbar by default, because it's rarely needed, but I left the NoScript button visible for temporary whitelisting purposes. (The HTTPS-E button can still be found in the Customize panel.)

I removed the search box and the "Flexible Space" around the URL bar, to give more room for v3 .onion domains. This seems OK given that the URL box also behaves as a search box.

I also included the Downloads button, but it auto-hides as long as no items have been download.

Here's what the result looks like:

Question: do we want to include a bookmarks button? It's not present in TBB 7.5 but maybe it's nice to have.

Last edited 3 months ago by arthuredelstein (previous) (diff)

comment:4 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam2018R added
Status: newneeds_review

comment:5 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam201806R added; TorBrowserTeam2018R removed

comment:6 Changed 3 months ago by cypherpunks

That's excellent Arthur, what I'd propose next is to place the Torbutton in the place of the home button which is very rarely needed (who needs to go back to about:tor?).

comment:7 in reply to:  3 ; Changed 3 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201806R removed
Status: needs_reviewneeds_revision

Replying to arthuredelstein:

Here's a proposed patch to try to clean up the toolbar:
https://github.com/arthuredelstein/tor-browser/commit/26237

I moved the HTTPS-Everywhere button off the toolbar by default, because it's rarely needed, but I left the NoScript button visible for temporary whitelisting purposes. (The HTTPS-E button can still be found in the Customize panel.)

I removed the search box and the "Flexible Space" around the URL bar, to give more room for v3 .onion domains. This seems OK given that the URL box also behaves as a search box.

One thing which is very handy is the search engine drop down in the search box. DDG often has not the up-to-date content I need, so I can easily select a different search engine for that purpose. Is that possible with the URL bar, too? If not, I think we should get the search box back. In general, I think we should get as close as possible to the layout which we have in the current stable and then open a ticket for redoing the toolbar properly together with ux-team input in case we feel we need that. (So, yes, no Home button)

Last edited 3 months ago by gk (previous) (diff)

comment:8 in reply to:  7 ; Changed 3 months ago by cypherpunks

Replying to gk:

One thing which is very handy is the search engine drop down in the search box. DDG often has not the up-to-date content I need, so I can easily select a different search engine for that purpose. Is that possible with the URL bar, too?

The answer is yes. Type a word, you can then try from a selection of search engines that appear in the bottom.

comment:9 in reply to:  8 Changed 3 months ago by gk

Replying to cypherpunks:

Replying to gk:

One thing which is very handy is the search engine drop down in the search box. DDG often has not the up-to-date content I need, so I can easily select a different search engine for that purpose. Is that possible with the URL bar, too?

The answer is yes. Type a word, you can then try from a selection of search engines that appear in the bottom.

Huh, indeed. I wonder how I missed that. Great, then, yes, let's leave out the search bar.

comment:10 Changed 3 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed
Priority: MediumVery High

Marked #26554 and #23547 as duplicate. comment:9:ticket:25693 has a good clean-up accoring to a cypherpunk.

comment:11 Changed 3 months ago by gk

Cc: ux-team intrigeri added

Changed 2 months ago by arthuredelstein

Attachment: toolbar_26237+1.png added

comment:12 Changed 2 months ago by arthuredelstein

Keywords: TorBrowserTeam201807R added; TorBrowserTeam201807 removed
Status: needs_revisionneeds_review

Here's a revised version without the home button (I'd suggest we consider adding back a home button in the next iteration).

https://github.com/arthuredelstein/tor-browser/commit/26237+1


comment:13 Changed 8 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Note that HTTPS-E does indeed show up on the toolbar on second start. That might be a case for #23359 but we'll need to deal with it during our security indicator redesign which is in the pipeline. Thus, I am fine leaving that issue as is for now.

Cherry-picked to tor-browser-60.1.0esr-8.0-1 (commit 51bc401c59cdaa7bf550a8ee955a27253285995e) (I adjusted the bug number of the commit and fixed a typo, fwiw).

Note: See TracTickets for help on using tickets.