#26250 closed defect (fixed)

Firefox 60 ESR compilation fails intermittently with Rust 1.25

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-rbm, TorBrowserTeam201806R
Cc: boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On one of my build machines I have seen intermittent Firefox compilation failures when building with Rust 1.25

17:37.81 thread '<unnamed>' panicked at 'failed to shut down worker thread', vendor/jobserver/src/lib.rs:650:17

It turns out Mozilla hit them as well (https://bugzilla.mozilla.org/show_bug.cgi?id=1445413) and put some duct tape over the problem. This landed in 1.26.

I think we should upgrade to this version which has the nice benefit that we could get rid of our patch for Linux as it is not needed anymore.

Child Tickets

Change History (7)

comment:1 Changed 19 months ago by gk

FWIW: I hit this when trying to check whether the nightlies on Linux are reproducible by building on different machines from the same commit and they are! \o/

comment:2 Changed 19 months ago by gk

Keywords: TorBrowserTeam201806R added
Status: newneeds_review

bug_26250_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26250_v2&id=483e1cb6132936a25387ad1fd9d311d18487c49b) has the version bump. This commit is on top of bug_24632_v2 to make it easier to test the whole thing for Linux and macOS.

comment:3 Changed 19 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201806R removed
Status: needs_reviewneeds_revision

The rust compiler for windows landed meanwhile and this bump breaks the win32 patch we need. We need to update it first.

comment:4 Changed 19 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: needs_revisionneeds_review

Okay, bug_26250_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26250_v3&id=5b32207650a878f8e432f85f55e9e131edaee988) is a thing now (rebased against master and on top of the other patches in bug_24632_v2).

comment:5 Changed 18 months ago by gk

Okay, I've rebased my patch against master and updated neersighted's patch (the original patch applies cleanly now as it was against 1.26.1 code). bug_26250_v4 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26250_v4&id=c62728741e6ebc6df4190b7c00d78b34a7789c2d) has all the changes for review.

comment:7 Changed 18 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

This looks good to me. I merged it to master with commit 85db911cee972e286b358bdabc50e0796823654d.

Note: See TracTickets for help on using tickets.