Opened 11 months ago
Closed 10 months ago
#26258 closed defect (fixed)
Rust tests don't fail on failure
| Reported by: | nickm | Owned by: | nickm |
|---|---|---|---|
| Priority: | Medium | Milestone: | Tor: 0.3.4.x-final |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Normal | Keywords: | 033-backport regression 034-must |
| Cc: | isis | Actual Points: | |
| Parent ID: | Points: | ||
| Reviewer: | catalyst | Sponsor: |
Description
Apparently, at least some versions of find won't fail when they exec something that fails. How delightful!
This means that our fix for #25560 isn't right. I'll try another here -- just a moment...
Child Tickets
Change History (10)
comment:1 Changed 11 months ago by
| Owner: | set to nickm |
|---|---|
| Status: | new → accepted |
comment:2 Changed 11 months ago by
| Status: | accepted → needs_review |
|---|
comment:3 Changed 11 months ago by
| Reviewer: | → catalyst |
|---|
comment:4 Changed 11 months ago by
Fails in Travis in cargo offline mode. Failure replicates when manually run. Maybe some Cargo.lock files need updating, or the external deps repo needs updating?
https://api.travis-ci.org/v3/job/387272070/log.txt
FAIL: src/test/test_rust.sh =========================== error: attempting to make an HTTP request, but --frozen was specified error: attempting to make an HTTP request, but --frozen was specified error: attempting to make an HTTP request, but --frozen was specified error: attempting to make an HTTP request, but --frozen was specified error: attempting to make an HTTP request, but --frozen was specified error: attempting to make an HTTP request, but --frozen was specified
comment:5 Changed 11 months ago by
| Status: | needs_review → needs_revision |
|---|
comment:6 Changed 10 months ago by
| Status: | needs_revision → needs_review |
|---|
So, the good news here is that this bug isn't mine: it's already present in Tor! The solution is to run Cargo from inside the corresponding directory.
I've updated my bug26258_033 branch, and pushed it to github too with https://github.com/torproject/tor/pull/149
comment:8 Changed 10 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | merge_ready → closed |
Woo; merged to 0.3.3 and forward!
comment:9 Changed 10 months ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
There was a bug: I should have said ${CARGO_ONLINE-"--frozen}, not ${CARGO_ONLINE:-"--frozen"}
The former treats an empty setting ("") as set, whereas the latter does not.
comment:10 Changed 10 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
ccf1eb3164a48de042dfdd8712f4b788bfefdc49 fixes this.
See my branch
bug26258_033?