Opened 15 months ago

Closed 10 months ago

Last modified 9 months ago

#26263 closed defect (fixed)

browser app icon positioned incorrectly in macOS DMG installer window

Reported by: mcs Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-8.0-issues, TorBrowserTeam201810R, tbb-backported
Cc: Ralph, steph, antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mcs)

In our ESR60-based builds the browser app icon is positioned incorrectly within the macOS DMG installer window. See ticket:24632#comment:14.

Child Tickets

Attachments (2)

macOS installer.png (75.8 KB) - added by mcs 10 months ago.
new macOS installer
Captura de pantalla 2018-10-17 a la(s) 8.43.47 AM.png (159.8 KB) - added by antonela 10 months ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 14 months ago by gk

Cc: pastly added

#26571 is a duplicate.

comment:2 Changed 14 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

More tickets for July.

comment:3 Changed 13 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:4 Changed 12 months ago by gk

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201808 removed

Moving our tickets to September 2018

comment:5 Changed 11 months ago by gk

Keywords: TorBrowserTeam201810 added; TorBrowserTeam201809 removed

Moving tickets to October

comment:6 Changed 11 months ago by mcs

Cc: Ralph added
Keywords: tbb-8.0-issues added

#27957 is a duplicate.

comment:7 Changed 11 months ago by mcs

Description: modified (diff)
Summary: browser app icon positioned incorrectly in DMG installer windowbrowser app icon positioned incorrectly in macOS DMG installer window

comment:8 Changed 11 months ago by gk

I saw this in action recently and it looks awful. IIRC the plan was to fix this with the new icons but there is no ETA for them. We should do this sooner. I guess the release in two weeks would be a good one.

comment:9 Changed 10 months ago by mcs

Kathy and I worked on this ticket last week (it seemed like an easy one to fix). However, so far we have failed to produce a new .DS_Store file that fixes the icon positioning problem without introducing a new problem. Specifically, after we create a new .DS_Store file which fixes the positioning problem, the "drag to install" background image is not shown at all (we also created a new background image which includes the new Tor Browser logo, but it makes no difference is we use the old image or the new one).

We also do not know why this icon positioning problem occurs in Tor Browser 8 but not in 7.5.6.

The .DS_Store file format is undocumented and there are not many tools for working with it. To create the .DS_Store file we tried both manual methods (i.e., use the Finder to set up everything correctly and then copy the resulting .DS_Store to the Tor Browser build) and an open source tool named dmgbuild that can generate .DS_Store files.

Our best idea for what to do try next is to switch our DMG files to use an HFS+ file system inside (rather than the ISO 9660 one which we currently use). Mozilla made a similar switch a while ago for cross-compiled builds; see https://bugzilla.mozilla.org/show_bug.cgi?id=1197325#c1 for an idea of what is involved. Our hope is that switching to HFS+ will fix the missing background problem and also give us other benefits such as the ability to use a custom volume icon (which is shown on the macOS desktop after you open a DMG).

We may need some help from boklm with the rbm changes that will be required, and there is also a risk that changing to HFS+ will result in larger DMG files.

comment:10 Changed 10 months ago by mcs

We thought of another idea and it is looking promising: manually creating a new .DS_Store file in the Finder on an old version of macOS works (I think that is how Kathy and I created the one we used for the alpha builds which included the sandbox profiles). Using that approach I think we can quickly create something that will work.

comment:11 Changed 10 months ago by mcs

Cc: steph antonela added
Keywords: TorBrowserTeam201810R added; TorBrowserTeam201810 removed
Status: newneeds_review

Here is a fix (which also fixes #25151):
https://gitweb.torproject.org/user/brade/tor-browser-build.git/commit/?h=bug26263-01&id=8043f2546a8b24a6cead0e0e18e8053e490fc4b3

I will attach a screenshot to show what the new macOS installer window looks like.

Kathy and I think we should try this in the alpha series first in case there are unforeseen problems. One issue that we know about is that on really old macOS systems (e.g., 10.6.x) the larger (@2x) image is used from background.tiff even on a @1x display. This is ugly, but since we only support macOS 10.9 and newer (which should handle the background correctly), it seems worthwhile to ignore that problem.

Changed 10 months ago by mcs

Attachment: macOS installer.png added

new macOS installer

comment:12 Changed 10 months ago by mcs

I just realized that my screenshot shows the .app extension. That is not displayed by default; on our Macs, Kathy and I always turn on the Finder's "Show all filename extensions" preference.

new macOS installer

Also, I forgot to mention that inside the .DS_Store file we set the window position to x=15, y=10,000. The y is measured from the bottom of the main display and the Finder is smart enough to not open the window off the top of the display, so this trick causes the installer window to be displayed near the top-left corner of the main display.

Last edited 10 months ago by mcs (previous) (diff)

comment:13 Changed 10 months ago by pastly

Cc: pastly removed

comment:14 Changed 10 months ago by antonela

yess \o/ thanks a lot for working on this!

comment:15 Changed 10 months ago by gk

I inspected the changes and they look good to me. Can anyone not being mcs/brade test the resulting .dmg and report back whether it looks good:

https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-osx64_en-US.dmg
https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-osx64_en-US.dmg.asc

FWIW: I thought we already have a bug for adapting the volume icon somewhere (I am sure I always wanted to get that fixed) but I did not find it. Mentioning https://bugzilla.mozilla.org/show_bug.cgi?id=1197325 there would be a good idea.

comment:16 Changed 10 months ago by antonela

Looks great on my end. Attached screenshot. Thanks!

comment:17 Changed 10 months ago by gk

Keywords: tbb-backport added
Resolution: fixed
Status: needs_reviewclosed

Great! I merged the patch to master (commit 8d7c170ac77f1a9901b1ef3fc36a9144ac3cd4cb). Let's test it in an alpha first but mark it for possible backport to the stable later on.

comment:18 Changed 9 months ago by gk

Backported to maint-8.0 (commit cb37fc36ffb8d21c99e90a61b6a31a8981b64e41).

comment:19 Changed 9 months ago by gk

Keywords: tbb-backported added; tbb-backport removed
Note: See TracTickets for help on using tickets.