#26281 closed enhancement (implemented)

Add .editorconfig?: it makes it easier to follow coding standards style with many editors

Reported by: juga Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

See more informatin in https://editorconfig.org/

Maybe it would be usefult to include it in the source code?.

Child Tickets

Change History (9)

comment:1 Changed 15 months ago by juga

See the current .editorconfig i'm using for tor repo in https://github.com/juga0/tor/blob/editorconfig/.editorconfig

comment:2 Changed 15 months ago by nickm

Milestone: Tor: 0.3.5.x-final
Status: newneeds_review

This looks like it would be a lot cleaner than my current approach (which is having special emacs code to detect that I'm editing Tor and to adjust my c-mode parameters accordingly).

comment:3 Changed 14 months ago by asn

Reviewer: dgoulet

comment:4 Changed 14 months ago by dgoulet

Status: needs_reviewmerge_ready

Small comment for an improvement on the PR but we could simply merge it and add it ourselves after actually... I'll give some hours to juga to maybe comment on it and then we should merge this.

This is 035 so won't get in after merge window opens on the 15th. Although, harmless to merge it in 034...

comment:5 Changed 14 months ago by juga

Commented back. There is not PR, but the the branch. Thanks.

comment:6 Changed 14 months ago by juga

Hmm, maybe we should also add a not in doc/HACKING/CodingStandards.md, so developers know what that file is for?

comment:7 Changed 14 months ago by nickm

That would be cool, if you have time!

comment:8 Changed 14 months ago by juga

Added it.

comment:9 Changed 14 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged the configuration file to 0.2.9 and forward, and the CodingStandards.md change to master!

Thanks, juga!

I've turned off my own c-mode hacks, and I'm going to see whether this works for me :)

Note: See TracTickets for help on using tickets.