Circuit display - Let's remove link from the Tor Button

I'm wondering if we should remove the "New Tor Circuit for this Site" link from the Tor Button. I think the shortcut works perfect for Power Users and since we have the main CTA at the display now, I don't see why we should have it on the menu. What do you think?

added TorBrowserTeam201807R component::applications/tor browser ff60-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-circuit-display tbb-torbutton type::enhancement labels

Trac:
Keywords: N/A deleted, tbb-circuit-display, tbb-torbutton, TorBrowserTeam201806 added

I agree! We will need to re-implement the keyboard shortcut (if we want to keep it) and then display the key combination in the button text, I guess. Does that sound reasonable?

Trac:
Cc: N/A to arthuredelstein

Replying to arthuredelstein:

I agree! We will need to re-implement the keyboard shortcut (if we want to keep it)

Please keep the keyboard shortcut :)

Trac:
Cc: arthuredelstein to arthuredelstein, dmr

Arthur and I discussed this idea about to have the link items placed in the top menu.

Raising the plan that eventually removes the Tor Button, Security Settings and Tor Network Settings may live in about:preferences and New Circuit an New Identity will live under File item at the OS top bar menu

Check the attachments to see how it might look https://trac.torproject.org/projects/tor/attachment/ticket/26321/26321.png

Replying to antonela:

... and New Circuit an New Identity will live under File item at the OS top bar menu
... on Mac OS only.

Putting both in the File menu works for me.

Another possibility is to put the "New Tor Circuit" and "New Identity" items in the "hamburger" menu (the one that is opened by clicking the right-most toolbar icon).

Yes! We may have both. Right now, Firefox has both options at both menus. Attached is the updated mockup.

Replying to mcs:

Another possibility is to put the "New Tor Circuit" and "New Identity" items in the "hamburger" menu (the one that is opened by clicking the right-most toolbar icon).

Trac:

That looks good and will work for Linux users and Windows useds :)

Tor Browser window height is a little more than 600px-ish, with this change the hamburger menu will dip below the window, and much more if there's an update notification. Is this a good compromise? (I myself don't care too much about that but it's a thing the UX team should consider.)

Arthur, I'm attaching here the Tor Button Icon to replace the current one. Please, let me know if you need any other kind of export. Also, could you clean the metadata of those files? Thanks!

Trac:
Tor_Button_Icon.zip

Replying to antonela:

Arthur, I'm attaching here the Tor Button Icon to replace the current one. Please, let me know if you need any other kind of export. Also, could you clean the metadata of those files? Thanks!

This icon looks very nice! I opened #26430 (moved) to track this issue.

Two patches for review:

• https://github.com/arthuredelstein/tor-browser/commit/26321
• https://github.com/arthuredelstein/torbutton/commit/26321

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201806 deleted, TorBrowserTeam201806R added

Moving reviews to July.

Trac:
Keywords: TorBrowserTeam201806R deleted, TorBrowserTeam201807R added

Trac:
Keywords: N/A deleted, ff60-esr added

Looks good. Applied to Torbutton master (commit 25786da78e5646ddbccaee769a9356e0b4f39e42) and tor-browser-60.1.0esr-8.0-1 (commit 9eef59c878e596b64efff9eafb0cc4bcc38f680c).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed