Opened 2 months ago

Closed 3 weeks ago

#26321 closed enhancement (fixed)

Circuit display - Let's remove link from the Tor Button

Reported by: antonela Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, tbb-circuit-display, TorBrowserTeam201807R, ff60-esr
Cc: arthuredelstein, dmr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm wondering if we should remove the "New Tor Circuit for this Site" link from the Tor Button. I think the shortcut works perfect for Power Users and since we have the main CTA at the display now, I don't see why we should have it on the menu. What do you think?

Child Tickets

Attachments (2)

26321.png (349.2 KB) - added by antonela 2 months ago.
Tor Button Icon.zip (18.4 KB) - added by antonela 2 months ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 2 months ago by gk

Keywords: tbb-torbutton tbb-circuit-display TorBrowserTeam201806 added

comment:2 Changed 2 months ago by arthuredelstein

Cc: arthuredelstein added

I agree! We will need to re-implement the keyboard shortcut (if we want to keep it) and then display the key combination in the button text, I guess. Does that sound reasonable?

Last edited 2 months ago by arthuredelstein (previous) (diff)

comment:3 in reply to:  2 Changed 2 months ago by dmr

Cc: dmr added

Replying to arthuredelstein:

I agree! We will need to re-implement the keyboard shortcut (if we want to keep it)

Please keep the keyboard shortcut :)

comment:4 Changed 2 months ago by antonela

Arthur and I discussed this idea about to have the link items placed in the top menu.

Raising the plan that eventually removes the Tor Button, Security Settings and Tor Network Settings may live in about:preferences and New Circuit an New Identity will live under File item at the OS top bar menu

Check the attachments to see how it might look
https://trac.torproject.org/projects/tor/attachment/ticket/26321/26321.png

comment:5 in reply to:  4 Changed 2 months ago by cypherpunks

Replying to antonela:

... and New Circuit an New Identity will live under File item at the OS top bar menu

... on Mac OS only.

comment:6 Changed 2 months ago by gk

Putting both in the File menu works for me.

comment:7 Changed 2 months ago by mcs

Another possibility is to put the "New Tor Circuit" and "New Identity" items in the "hamburger" menu (the one that is opened by clicking the right-most toolbar icon).

comment:8 in reply to:  7 Changed 2 months ago by antonela

Yes! We may have both. Right now, Firefox has both options at both menus.
Attached is the updated mockup.

Replying to mcs:

Another possibility is to put the "New Tor Circuit" and "New Identity" items in the "hamburger" menu (the one that is opened by clicking the right-most toolbar icon).

Changed 2 months ago by antonela

Attachment: 26321.png added

comment:9 Changed 2 months ago by cypherpunks

That looks good and will work for Linux users and Windows useds :)

comment:10 Changed 2 months ago by cypherpunks

Tor Browser window height is a little more than 600px-ish, with this change the hamburger menu will dip below the window, and much more if there's an update notification. Is this a good compromise? (I myself don't care too much about that but it's a thing the UX team should consider.)

comment:11 Changed 2 months ago by antonela

Arthur, I'm attaching here the Tor Button Icon to replace the current one. Please, let me know if you need any other kind of export. Also, could you clean the metadata of those files?
Thanks!

Changed 2 months ago by antonela

Attachment: Tor Button Icon.zip added

comment:12 in reply to:  11 Changed 2 months ago by arthuredelstein

Replying to antonela:

Arthur, I'm attaching here the Tor Button Icon to replace the current one. Please, let me know if you need any other kind of export. Also, could you clean the metadata of those files?
Thanks!

This icon looks very nice! I opened #26430 to track this issue.

comment:13 Changed 8 weeks ago by arthuredelstein

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

comment:14 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201807R added; TorBrowserTeam201806R removed

Moving reviews to July.

comment:15 Changed 5 weeks ago by arthuredelstein

Keywords: ff60-esr added

comment:16 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to Torbutton master (commit 25786da78e5646ddbccaee769a9356e0b4f39e42) and tor-browser-60.1.0esr-8.0-1 (commit 9eef59c878e596b64efff9eafb0cc4bcc38f680c).

Note: See TracTickets for help on using tickets.