Opened 10 months ago

Last modified 2 months ago

#26337 needs_information enhancement

Investigate making rust error types use the failure crate

Reported by: isis Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, technical-debt, tor-modularity, 035-removed-20180711
Cc: isis, chelseakomlo Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description (last modified by chelseakomlo)

As our Rust code increases, we'll eventually want a nicer way to convert between error types than we currently have. We'll probably want to use boats's failure crate. They mentioned a while ago that they were going to make a 1.0.0 release soon, and afaict there's not really anything about the current release that is expected to change, so we can probably start working on this now-ish.

[update] This ticket is pending stability of the failure crate and the direction of the error trait in Rust https://github.com/rust-lang/rfcs/pull/2504

Child Tickets

Change History (8)

comment:1 Changed 10 months ago by chelseakomlo

Is this going to be incorporated into the Rust standard library? If so, should we wait for it? (as to not pull in unnecessary external crates).

comment:2 Changed 10 months ago by isis

Description: modified (diff)

comment:3 Changed 8 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:4 in reply to:  1 ; Changed 7 months ago by cypherpunks3

Replying to chelseakomlo:

Is this going to be incorporated into the Rust standard library? If so, should we wait for it?

Nobody knows for sure. It's in flux apparently. The "1.0 soon" plan was canceled.

Also, should this be a child ticket of #25628?

comment:5 in reply to:  4 Changed 7 months ago by chelseakomlo

Replying to cypherpunks3:

Replying to chelseakomlo:

Is this going to be incorporated into the Rust standard library? If so, should we wait for it?

Nobody knows for sure. It's in flux apparently. The "1.0 soon" plan was canceled.

Also, should this be a child ticket of #25628?

Thanks- I think waiting to see how this evolves is a good idea. I'll set this to "needs more information" for now.

comment:6 Changed 7 months ago by chelseakomlo

Description: modified (diff)
Status: newneeds_information
Summary: make rust error types use the failure crateInvestigate making rust error types use the failure crate

comment:7 Changed 7 months ago by chelseakomlo

Cc: chelseakomlo added

comment:8 Changed 2 months ago by gaba

Sponsor: Sponsor8-can
Note: See TracTickets for help on using tickets.