#26346 closed defect (invalid)

Update prompt from 7.5.5 to the same version

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Yesterday I let Tor Browser update from 7.5.4 to 7.5.5. It used the incremental method and apparently the process was successful. I restarted the browser and got presented with the changelog page. The page about:tor shows "7.5.5" in the top right corner. The dialog at Help/About Tor Browser says "7.5.5 (based on Mozilla Firefox 52.8.1) (64-bit)".

From the root of the application directory I can see the file "Browser/tbb_version.json". It says:

{"version":"7.5.5","architecture":"linux64","channel":"release","locale":"en-US"}

Searching for "7.5" in about:config I can see:

browser.startup.homepage_override.torbrowser.version    7.5.5
extensions.lastTorBrowserVersion                        7.5.4
extensions.torbutton.lastBrowserVersion                 7.5.5
torbrowser.version                                      7.5.5

Yet the "Software Update" dialog (updates.xul) still prompts me to update to 7.5.5.

What gives?

Child Tickets

Change History (4)

comment:1 Changed 16 months ago by gk

Status: newneeds_information

Do you have your Tor Browser modified in any way? If so, how? And this problem persists after a restart?

comment:2 Changed 16 months ago by gk

Cc: mcs brade added

Hm, I wonder why extensions.lastTorBrowserVersion is stil 7.5.4. I can't seem to reproduce that here.

comment:3 Changed 16 months ago by mcs

Also, can you please use about:config to set app.update.log to true, check for an update, and see what message appear in the browser console? I am especially interested in the value used for the update URL.

comment:4 Changed 16 months ago by cypherpunks

Resolution: invalid
Status: needs_informationclosed

gk:

Do you have your Tor Browser modified in any way? If so, how? And this problem persists after a restart?

Sharp! It seems that's where the problem lay. That installation had a few minor tweaks, indeed. An oversight in one of my scripts (which I use to patch some things) meant that a few files from the 7.5.4 Browser/omni.ja ended up in the 7.5.5 installation sometime during or after the updater process swapped the files over. This resulted in the constant TOR_BROWSER_VERSION having the wrong value.

I presume this explains the observations.

mcs:

Also, can you please use about:config to set app.update.log to true, check for an update, and see what message appear in the browser console? I am especially interested in the value used for the update URL.

The update URL I saw was https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/7.5.4/en-US?force=1.

I have cleaned up the mess and I no longer get the update prompt.

Sorry for the noise.

Note: See TracTickets for help on using tickets.