Make sure only Windows users on Windows7+ are trying to use Tor Browser based on ESR60

[gk]

The miminum requirement for Firefox 60 is Windows 7 (which means there is no Windows XP and no Windows Vista anymore supported). We should make sure that

a) Tor Browser users on Windows XP and Windows Vista are not updated to the new Tor Browser (ideally they would get to know what is going on at least once).

b) Tor Browser users on Windows XP and Windows Vista are not trying to install Tor Browser 8 in the first place.

[boklm]

For a), it seems we could use the minSupportedOSVersion attribute that was added in #13047.

I see that the updater is checking minSupportedOSVersion like this:

  if (update.hasAttribute("unsupported")) {
    this.unsupported = ("true" == update.getAttribute("unsupported"));
  } else if (update.hasAttribute("minSupportedOSVersion")) {
    let minOSVersion = update.getAttribute("minSupportedOSVersion");
    try {
      let osVersion = Services.sysinfo.getProperty("version");
      this.unsupported = (Services.vc.compare(osVersion, minOSVersion) < 0);
    } catch (e) {}
  }

So we need to find what is the value of Services.sysinfo.getProperty("version") on Windows 7.

[mcs]

Replying to boklm:

So we need to find what is the value of Services.sysinfo.getProperty("version") on Windows 7.

The short answer is "6.1".

The longer answer is that PR_GetSystemInfo() is used by Services.sysinfo to obtain OS version information. On Windows, the implementation is in _MD_WindowsGetSysInfo() which constructs a string as dwMajorVersion.dwMinorVersion from a OSVERSIONINFO struct that is filled in via a call to the Windows API function GetVersionEx(). I used the Firedox browser console in to obtain the 6.1 answer, and it matches the data in the table that is included in the following page:

​https://msdn.microsoft.com/en-us/library/windows/desktop/ms724834(v=vs.85).aspx

[cypherpunks]

Dropping support can't be an enhancement, it's a shame of Mozilla corp.

[cypherpunks]

Replying to cypherpunks:

Dropping support can't be an enhancement, it's a shame of Mozilla corp.

Yeah let's keep supporting the meme of security that is WinXP.

[sukhbir]

Sorry for missing something obvious here, but for "b) Tor Browser users on Windows XP and Windows Vista are not trying to install Tor Browser 8 in the first place.", would it make sense to initiate a check from NSIS rather than Tor Browser?

[gk]

Replying to sukhbir:

Sorry for missing something obvious here, but for "b) Tor Browser users on Windows XP and Windows Vista are not trying to install Tor Browser 8 in the first place.", would it make sense to initiate a check from NSIS rather than Tor Browser?

Yes, that check needs in the NSIS script that generates the .exe.

[pospeselr]

Two small patches to fix this, one in the update_response config, adding "minSupportedOSVersion: 6.1" string for win32 and win64 builds. The other is to the nsis build script which adds the following pop-up to the installer when it's detected to be running on a version of windows older than Windows 7 (verified in Vista and 7 VMs).

One other thing I noticed while looking at the nsis script is that we're providing the option to add Desktop and Start Menu shortcuts. Since we don't provide an uninstaller to clean up the Start Menu, should that be removed, or at least put the Start Menu shortcut generation into a second not auto-selected option? I would think most users probably wouldn't remember to delete the Start Menu shortcut if they delete Tor Browser.

[boklm]

I merged the update_responses_config.yml patch to master as commit 2b04f4ee916a43a70c436a52c83205eda5f38648.

[gk]

Moving reviews to July.

[boklm]

The patch for the installer looks good to me, so I opened a pull request to get it merged in the upstream git repository:
​https://github.com/moba/tbb-windows-installer/pull/2

[boklm]

Replying to boklm:

The patch for the installer looks good to me, so I opened a pull request to get it merged in the upstream git repository:
​https://github.com/moba/tbb-windows-installer/pull/2

The patch has been merged and a new version tagged. Commit 7903f5828c835e52722101a83450bbeb29fc2007 is using the new tbb-windows-installer tag.