Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#26362 closed defect (fixed)

Use old MAR format when generating the MAR files for the first esr60-based alpha

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201806R
Cc: boklm, brade, mcs Actual Points:
Parent ID: #26050 Points:
Reviewer: Sponsor:

Description

Esr52-based Tor Browsers don't understand the LZMA compressed MAR files. We need to create the MAR files for the first esr60-based release using the old BZIP2 format. This can be done by setting MAR_OLD_FORMAT=1 before generating both the full and the incremental MAR files.

We should remove that patch once we generate the MAR files after the first esr60-based release.

Child Tickets

Change History (3)

comment:1 Changed 3 months ago by gk

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: newneeds_review

bug_26362 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26362&id=befc4910feb0eee2016e10000ed31e3fea7ef6b1) has a patch for review. I'll file a follow-up ticket keeping track of removing MAR_OLD_FORMAT=1 again, later on.

boklm: I did not find much about capture_exec() but I assumed that the env vars set are passed along to it. Let me know if thats not the case and I can try to rip those out of the Makefile rules and put them directly into the capture_exec() calls.

comment:2 in reply to:  1 Changed 3 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

bug_26362 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_26362&id=befc4910feb0eee2016e10000ed31e3fea7ef6b1) has a patch for review. I'll file a follow-up ticket keeping track of removing MAR_OLD_FORMAT=1 again, later on.

This looks good to me. I pushed it to master as commit befc4910feb0eee2016e10000ed31e3fea7ef6b1.

boklm: I did not find much about capture_exec() but I assumed that the env vars set are passed along to it. Let me know if thats not the case and I can try to rip those out of the Makefile rules and put them directly into the capture_exec() calls.

Yes, like normal exec the env vars should be passed along.

comment:3 Changed 3 months ago by boklm

I opened #26410 to remove it from the second esr60-based alpha and #26411 to remove it from the second esr60-based stable release.

Note: See TracTickets for help on using tickets.