Opened 9 months ago

#26366 new defect

Possible duplicated logic in connection_edge_finished_connecting() and connection_exit_connect()

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor-hs
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There's some possible duplicated logic in connection_edge_finished_connecting() and connection_exit_connect():

When conn->state = EXIT_CONN_STATE_OPEN is set we have some duplicated code on when to begin writing. There is a comment that might be relevant around some Windows logic in the switch/case block around the result variable in connection_exit_connect().

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.