Opened 4 months ago

Closed 7 weeks ago

#26367 closed defect (implemented)

Consider removing tor2web mode

Reported by: ahf Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor2web, 035-roadmap-master, tor-hs, 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: Points:
Reviewer: teor Sponsor:

Description

It sounds like tor2web mode wont work after the DoS protection code was added.

Would it make sense to get rid of this?

Child Tickets

TicketStatusOwnerSummaryComponent
#19664closedIPv6-only Tor2web should use a 3-hop path on unreachable or failed intro or rendCore Tor/Tor

Change History (14)

comment:1 Changed 4 months ago by cypherpunks

+1000000000000000000000000000000000000000000000000000000000000000000000000000000000…

Edit: some browsers don't wrap long lines very well

Last edited 3 months ago by teor (previous) (diff)

comment:2 Changed 4 months ago by nickm

Keywords: 035-proposed added

comment:3 Changed 4 months ago by dgoulet

Keywords: tor2web added

comment:4 Changed 3 months ago by nickm

Keywords: 035-roadmap-proposed added; 035-proposed removed

comment:5 Changed 3 months ago by dgoulet

Keywords: 035-roadmap-master added; 035-roadmap-proposed removed
Owner: set to dgoulet
Status: newaccepted

comment:6 Changed 3 months ago by dgoulet

Keywords: tor-hs added
Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Status: acceptedneeds_review

Here it is: https://github.com/torproject/tor/pull/218

Branch: bug26367_035_01

comment:7 Changed 3 months ago by cypherpunks

don't forget to update the manual
https://www.torproject.org/docs/tor-manual.html.en

comment:8 Changed 3 months ago by teor

Status: needs_reviewneeds_revision

ENABLE_TOR2WEB_MODE sets NON_ANONYMOUS_MODE_ENABLED.
I don't think there is any other supported way to set NON_ANONYMOUS_MODE_ENABLED.

So let's delete all references to NON_ANONYMOUS_MODE_ENABLED as well.
I marked them on the pull request.

comment:9 Changed 3 months ago by nickm

Keywords: 035-triaged-in-20180711 added

comment:10 Changed 3 months ago by dgoulet

Status: needs_revisionneeds_review

Thanks teor!

I've pushed two extra commits to remove any mentions of them and their associated functions!

comment:11 Changed 3 months ago by teor

Reviewer: teor
Status: needs_reviewmerge_ready

Ok, looks good to me, let's get it merged,
I opened #26788 for the unrelated make distcheck error.

comment:12 Changed 7 weeks ago by nickm

Looks okay to merge, but needs a changes file.

comment:13 in reply to:  12 Changed 7 weeks ago by dgoulet

Replying to nickm:

Looks okay to merge, but needs a changes file.

Fixup commit has it: 5b44e56e08f7922d

comment:14 Changed 7 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged yesterday :)

Note: See TracTickets for help on using tickets.