Opened 2 years ago

Last modified 21 months ago

#26369 new defect

Re-fetch onion service descriptor for isolated request

Reported by: sysrqb Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-client, tbb-needs, 040-roadmap-proposed, 040-deferred-20190220
Cc: gk, mahrud, dmr, neel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When tor receives a new request for connecting to an onion service and this request has different isolation flags/parameters than a previous (recent) request, then tor should re-fetch the service descriptor (if we already have it). Currently, tor notices it already has the descriptor in its cache and it doesn't refetch. This is a nice performance optimization, but if a client is requesting an isolated circuit for an onion service, then we shouldn't leak that we already have the descriptor in our cache.

Instead of only using the onion service name as the map-key, we can add a unique value of the circuit isolation information (hash?).

Child Tickets

Change History (12)

comment:1 Changed 2 years ago by gk

Cc: gk added

comment:2 Changed 2 years ago by teor

Component: Core TorCore Tor/Tor
Keywords: tbb-wants 035-proposed tor-hs tor-client added
Milestone: Tor: unspecified

comment:3 Changed 2 years ago by arma

Cc: mahrud added

comment:4 Changed 2 years ago by nickm

Keywords: 035-roadmap-proposed added; 035-proposed removed

comment:5 Changed 2 years ago by teor

Keywords: tbb-needs added; tbb-wants removed

Prefer the more common tbb-needs to tbb-wants.
There doesn't appear to be any difference in how much TBB needs based on the flag.

comment:6 Changed 2 years ago by dmr

Cc: dmr added

comment:7 Changed 2 years ago by neel

Owner: set to neel
Status: newassigned

comment:8 Changed 2 years ago by neel

Cc: neel added

comment:9 Changed 2 years ago by neel

Owner: neel deleted

comment:10 Changed 2 years ago by neel

Status: assignednew

comment:11 Changed 23 months ago by teor

Keywords: 040-roadmap-proposed added; 035-roadmap-proposed removed
Milestone: Tor: unspecifiedTor: 0.4.0.x-final

These features or long-term bug fixes probably won't make it into 0.3.5

comment:12 Changed 21 months ago by nickm

Keywords: 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

Note: See TracTickets for help on using tickets.