Opened 5 months ago

Closed 5 months ago

#26372 closed defect (implemented)

Search for python3 with a better list of names.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Right now we search with:

AC_CHECK_PROGS(PYTHON, [python python2 python2.7 python3 python3.3])

But we'd like to prefer python3, and we'd like to prefer more recent versions. Ben McGinnes, who reported this bug, recommends

AC_CHECK_PROGS(PYTHON, [python3.6 python3.5 python3.4 python3.3 python3 python2.7 python2])

As an alternative, he suggests that we have a look at the GPGME Python binding M4 files, modulo license issues.

Personally, I'm thinking we'd like something like "python3, then known python3.x versions in descending order, then python, then python2, then python 2.7".

Having typed this ticket out, "Python" no longer looks like a word to me.

Child Tickets

Change History (6)

comment:1 Changed 5 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 5 months ago by nickm

Status: acceptedneeds_review

See my branch feature26372_029.

comment:3 Changed 5 months ago by nickm

Status: needs_reviewneeds_revision

Nick, where did you put this code? That branch is empty.

comment:4 Changed 5 months ago by nickm

Status: needs_revisionneeds_review

Found it and pushed it. Also made a PR at https://github.com/torproject/tor/pull/167

comment:5 Changed 5 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

ack.

comment:6 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Okay, merged to 0.2.9 and forward!

Note: See TracTickets for help on using tickets.