Opened 2 years ago

Closed 2 years ago

Last modified 17 months ago

#26383 closed enhancement (implemented)

Move structures out of or.h

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 2
Parent ID: Points:
Reviewer: dgoulet Sponsor: Sponsor8-can


As part of the big 0.3.5 refactoring, we want to split or.h into lots of little headers. And as part of that, we want to get each structure into its own header.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by nickm

Status: assignedneeds_review

The branch is "split_or_h", and there's a pull request here:

This branch does not move all the structures yet, but I'd like to do this batch first, and then take care of the remainder.

If possible, I'd like to take this right away in 0.3.5.

Notes for the reviewer:

  • If possible, please separate stuff that I must fix before merging from stuff that would be ok to fix afterwards: if this branch sits unmerged for a long time, it will rot badly.
  • You might find the --color-moved option in the latest versions of git to be useful in verifying that certain commits are pure code movement.

comment:2 Changed 2 years ago by dgoulet

Reviewer: dgoulet

comment:3 Changed 2 years ago by dgoulet

Status: needs_reviewmerge_ready

lgtm for the first step! Merge early ftw!

comment:4 Changed 2 years ago by nickm

Resolution: implemented
Status: merge_readyclosed

There, merged!

comment:5 Changed 17 months ago by nickm

Actual Points: 2
Note: See TracTickets for help on using tickets.