Changes between Initial Version and Version 1 of Ticket #26398, comment 6


Ignore:
Timestamp:
Jul 3, 2018, 1:10:42 AM (12 months ago)
Author:
isis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26398, comment 6

    initial v1  
    55> I think I'll need it for the PrivCount noise branch. Or did we fix the linker issues?
    66 
    7 Looking at the current status of #25386 it seems there's still going to be linker issues, particularly from doctests, for the time being until everything has rustc 1.27 stable (when the `-C` option [https://github.com/rust-lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f was added] to rustdoc).
     7Looking at the current status of #25386 it seems there's still going to be linker issues, particularly from doctests, for the time being until everything has rustc 1.27 stable (when the `-C` option [https://github.com/rust-lang/rust/pull/49956/commits/1a0d7a8207907e2459db8df72a8f604cdcc8285f was added] to rustdoc). But also, feel free to disagree.
    88
    99It might be good to have a configurable way to disable this stuff until all the issues are resolved, that way teor and I can continue writing tests as we would normally for now.  In the future, it also gives us an easier way to enable running the tests all the time, when we remove C code (e.g. if I were to write a sha2 or keccak implementation and we used that instead of the C code).