Opened 2 years ago

Closed 2 years ago

#26400 closed defect (fixed)

remove --all-features from

Reported by: isis Owned by: isis
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: rust, tor-test, fast-fix
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor: Sponsor8-can


After #26399, none of our crates will have any features. However, we'd like to feature-gate testing C code from Rust (#26398) as a temporary workaround to #25386, so we need to remove the --all-features flag. The --all-features flags was probably a bad idea to begin with, as many crates have mutually incompatible features (e.g. curve25519-dalek has features for different field implementation backends).

Child Tickets

Change History (4)

comment:1 Changed 2 years ago by isis

Status: assignedneeds_review

See my bug26400 branch.

comment:3 Changed 2 years ago by catalyst

Status: needs_reviewmerge_ready

Thanks! Looks good to me!

comment:4 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Cherry-picked to 0.3.4 and merged forward

Note: See TracTickets for help on using tickets.