Opened 5 months ago

Closed 3 months ago

#26409 closed defect (fixed)

Language prompt is shown twice at first start in Tor Browser based on ESR60

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, tbb-torbutton, AffectsTails, TorBrowserTeam201808R
Cc: mcs, brade, viktor_jaegerskuepper@…, intrigeri, arthuredelstein Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The "spoof locale" prompt is shown twice in a non-en-US Tor Browser. I guess we can retire the Torbutton version?

Child Tickets

Change History (10)

comment:1 Changed 5 months ago by viktorj

Cc: viktor_jaegerskuepper@… added

I believe there is a conflict between what Torbutton does and what is already included in Firefox. When I first denied to spoof the locale (twice), but later clicked on the corresponding box in the "General" part of about:preferences to set it to "on" ("spoof locale"), in this session the "accepted languages" seem to be changed to only include en-us/en. But after closing and restarting Tor Browser my locale (de) is included again, although the checkbox setting is not changed. I first noticed this when visiting trac.torproject.org. What is even more weird: When I uncheck the box to delete "German [de]", after a restart it is there again, independent of the setting of the checkbox.

comment:2 Changed 4 months ago by intrigeri

Cc: intrigeri added
Keywords: AffectsTails added

This particularly affects Tails users who will see this every time they start Tor Browser in Tails. Besides, previously we could set extensions.torbutton.prompted_language to true and hide the prompt, but that does not work anymore (tried patching defaults/preferences/000-tor-browser.js in browser/omni.ja, prefs.js and user.js in the profile directory). Thankfully, by setting privacy.spoof_english to 2, at least we have only one prompt, but we ideally we want zero in Tails :)

comment:3 Changed 4 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

More tickets for July.

comment:4 Changed 4 months ago by gk

Priority: MediumHigh

comment:5 Changed 4 months ago by arthuredelstein

Cc: arthuredelstein added

comment:6 Changed 4 months ago by intrigeri

Is there a chance this will be fixed by August 7? If not, I'll try to schedule time on August 8-9 to work on this myself.

comment:7 Changed 4 months ago by gk

There is!

comment:8 Changed 3 months ago by gk

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201807 removed
Status: newneeds_review
Last edited 3 months ago by intrigeri (previous) (diff)

comment:9 Changed 3 months ago by intrigeri

I've tested this in a running Tails system with 8.0a9 (by applying your patches inside omni.ja and the torbutton xpi) and it worked just fine. Thanks!

Code review passes modulo a couple nitpicks:

  • website/design/design.xml and website/design/index.html.en still refer to the obsolete extensions.torbutton.spoof_english; this probably does not block merging these branches though since even without this fix, the corresponding sections were obsolete already (they don't mention the new Firefox locale spoofing feature that we now rely upon)
  • the localized torbutton.properties files still have torbutton.popup.prompted_language; maybe they're updated automatically later during the build or release process?

I'm not a Torbutton developer so even though I'm quite at ease with this part of the code, I'm leaving this is needs_review. Let me know if I should have been bold enough to make this merge_ready.

comment:10 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for the review (and it counts as one :) ). We don't use merge_ready, thus just leaving state is fine.

Regarding your two points:

1) The design doc currently specifies the state of Tor Browser 7.0. Once we update it to 8.0 mentioning the pref will be removed.

2) Yes, once we fetch the updated localized files they won't have the string in it anymore after it's gone in the en version. Thus, we are good here.

The torbutton commit got applied to master (e950aeac23670983bedd84c6526bb9a865450a25) and the tor-browser one to tor-browser-60.1.0esr-8.0-1 (49b80d55c275d4a59484b8e955d9d4eeac2d8d44), thanks!

Note: See TracTickets for help on using tickets.