Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#26415 closed defect (fixed)

doctests in src/rust/crypto fail compilation

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.1-alpha
Severity: Normal Keywords: rust, tor-tests
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8-can

Description

After #26378 fixed compilation of regular tests in src/rust/crypto, compilation errors remain in the doctests.

Child Tickets

Change History (3)

comment:1 Changed 5 weeks ago by catalyst

Status: assignedneeds_review

Patch at https://github.com/torproject/tor/pull/161

Note there are still linker errors. You'll probably have to cargo test --doc explicitly to get verify that the doctests compile. (The regular tests failing to link prevents cargo from attempting the doctests.)

comment:2 Changed 5 weeks ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay; this looks okay to me, and it's blocking CI from succeeding, so I'm merging this. We can reopen if there are any changes here we shouldn't have made.

comment:3 Changed 5 weeks ago by chelseakomlo

I looked this over yesterday (without manual QA though), and it looked ok to me (without context on why the original doctests weren't updated to match code).

Note: See TracTickets for help on using tickets.