Opened 11 months ago

Closed 11 months ago

Last modified 5 months ago

#26427 closed defect (implemented)

Remove circularity surrounding functions called by tor_logv()

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: refactoring
Cc: Actual Points: 1
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

These functions should not be allowed to log failure fail when tor_logv calls them, because tor_logv is required for logging.

This will help us untangle some call cycles at the bottom of our callgraph, and thereby help with our library refactoring

Child Tickets

TicketStatusOwnerSummaryComponent
#26426closednickmRemove dmalloc supportCore Tor/Tor

Change History (6)

comment:1 Changed 11 months ago by nickm

Status: assignedneeds_review

See my branch logging_circularity, which also includes a fix for #26426.

comment:3 Changed 11 months ago by dgoulet

Keywords: refactoring added
Reviewer: dgoulet
Status: needs_reviewmerge_ready

One comment about all this on the PR. And travis unhappy. Feel free to merge after.

comment:4 Changed 11 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged after fixes!

comment:5 Changed 11 months ago by nickm

I closed #19328 as a duplicate of this.

comment:6 Changed 5 months ago by nickm

Actual Points: 1
Note: See TracTickets for help on using tickets.