Opened 3 months ago

Closed 3 months ago

#26430 closed defect (fixed)

New torbutton icons

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201806R
Cc: antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

antonela has created some new icons for our torbutton. This ticket is to track creating a patch to add these. The current version is here:

https://trac.torproject.org/projects/tor/attachment/ticket/26321/Tor%20Button%20Icon.zip

Child Tickets

Attachments (2)

Tor Button Update.zip (7.7 KB) - added by antonela 3 months ago.
Icon-Tor-Update.txt (3.7 KB) - added by antonela 3 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 3 months ago by arthuredelstein

(Note to myself: we need to remove any metadata from these image files.)

comment:2 Changed 3 months ago by antonela

Update Tor .gif, also attached here.
Update Tor Browser flow is being discussed at #25694 tho.
Photoshop said they removed my metadata, but if you can check it, better. Thanks!

Changed 3 months ago by antonela

Attachment: Tor Button Update.zip added

Changed 3 months ago by antonela

Attachment: Icon-Tor-Update.txt added

comment:3 Changed 3 months ago by antonela

I just attached a .txt which is the .svg file (trac doesn't trust me to upload .svg files)
You just need to change the file extension.

comment:4 in reply to:  3 Changed 3 months ago by cypherpunks

Replying to antonela:

trac doesn't trust me to upload .svg files

Or upload it to https://catbox.moe then web archive it with https://web.archive.org/save/*

comment:5 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam201806R added
Status: newneeds_review

comment:6 Changed 3 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201806R removed
Status: needs_reviewneeds_revision

It seems those .svg files still contain metadata? See your comment:1.

comment:7 in reply to:  6 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam201806R added; TorBrowserTeam201806 removed
Status: needs_revisionneeds_review

Replying to gk:

It seems those .svg files still contain metadata? See your comment:1.

Yeah, I did remove what I thought was metadata of any significance. But now I have removed the rest. :)

https://github.com/arthuredelstein/torbutton/commit/26430+1

comment:8 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good and works for me on Linux and Windows. Merged to master (commit 32e63d587ac4de0f47ef13db8625a474d0492d34) and I guess I'll squeeze into 8.0a9.

Note: See TracTickets for help on using tickets.